From b9cccf7b0de30bce2407278276bda5bda5c9da93 Mon Sep 17 00:00:00 2001 From: Dom Del Nano Date: Fri, 19 Dec 2025 16:34:13 +0000 Subject: [PATCH 1/2] Replace deprecated std::result_of with std::invoke_result Signed-off-by: Dom Del Nano --- src/carnot/udf/udtf.h | 6 +++--- src/common/base/utils.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/carnot/udf/udtf.h b/src/carnot/udf/udtf.h index 3fe5c4d296a..c16813c1b22 100644 --- a/src/carnot/udf/udtf.h +++ b/src/carnot/udf/udtf.h @@ -185,7 +185,7 @@ class UDTFTraits { template typename std::enable_if_t::HasInitArgsFn(), bool> static constexpr HasCorrectInitArgsSignature() { - return CorrectInitArgsTypeHelper>::value; + return CorrectInitArgsTypeHelper>::value; } template @@ -231,7 +231,7 @@ class UDTFTraits { static constexpr bool HasCorrectOutputRelationFnSignature() { return HasOutputRelationFn() && CorrectOutputRelationTypeHelper< - std::result_of_t>::value; + std::invoke_result_t>::value; } /** @@ -244,7 +244,7 @@ class UDTFTraits { * @return */ static constexpr bool HasCorrectExectorFnReturnType() { - return HasExecutorFn() && std::is_same_v, + return HasExecutorFn() && std::is_same_v, udfspb::UDTFSourceExecutor>; } diff --git a/src/common/base/utils.h b/src/common/base/utils.h index 9a7b889b48b..675c50e51a0 100644 --- a/src/common/base/utils.h +++ b/src/common/base/utils.h @@ -363,7 +363,7 @@ constexpr auto ArrayTransform(const std::array& arr, F&& f) { template constexpr auto ArrayTransform(const std::array&, F&&) { - return std::array, 0>{}; + return std::array, 0>{}; } // Attempts to cast raw value into an enum, and returns error if the value is not valid. From dcfa0bface6b22e57d4b1d9677d139e32ba6c1fd Mon Sep 17 00:00:00 2001 From: Dom Del Nano Date: Fri, 19 Dec 2025 16:40:21 +0000 Subject: [PATCH 2/2] Fix linting Signed-off-by: Dom Del Nano --- src/carnot/udf/udtf.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/carnot/udf/udtf.h b/src/carnot/udf/udtf.h index c16813c1b22..4f05dfacd4e 100644 --- a/src/carnot/udf/udtf.h +++ b/src/carnot/udf/udtf.h @@ -231,7 +231,7 @@ class UDTFTraits { static constexpr bool HasCorrectOutputRelationFnSignature() { return HasOutputRelationFn() && CorrectOutputRelationTypeHelper< - std::invoke_result_t>::value; + std::invoke_result_t>::value; } /** @@ -244,7 +244,7 @@ class UDTFTraits { * @return */ static constexpr bool HasCorrectExectorFnReturnType() { - return HasExecutorFn() && std::is_same_v, + return HasExecutorFn() && std::is_same_v, udfspb::UDTFSourceExecutor>; }