From bfc3abbabf89c2cb22762f88d65791ebb9165452 Mon Sep 17 00:00:00 2001 From: Felipe Santos Date: Sat, 30 Mar 2024 13:34:10 -0300 Subject: [PATCH 1/2] Avoid printing GITHUB_TOKEN on bk docker --- bin/bk-docker | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bin/bk-docker b/bin/bk-docker index 2190001f..02fc3cb0 100755 --- a/bin/bk-docker +++ b/bin/bk-docker @@ -23,6 +23,7 @@ d="$(cd "$(dirname "$0")/.." && pwd)" if [ -z "$GITHUB_TOKEN" ]; then GITHUB_TOKEN=$(pkgx gh auth token) + export GITHUB_TOKEN fi if [ "$1" = --pull ]; then @@ -77,7 +78,7 @@ exec docker run \ --volume "$VOLUME_NAME:/root/.pkgx" \ --env DENO_DIR=/root/.pkgx/.cache/deno \ --env PKGX_PANTRY_PATH=/work \ - --env GITHUB_TOKEN=$GITHUB_TOKEN \ + --env GITHUB_TOKEN \ --env CLICOLOR_FORCE=1 \ --workdir /work \ pkgxdev/pkgx \ From 7ad306590649a0fdeb5c0559991cc3c923f9b422 Mon Sep 17 00:00:00 2001 From: Felipe Santos Date: Sat, 30 Mar 2024 14:30:34 -0300 Subject: [PATCH 2/2] Prevent zombie processes and properly handle Ctrl+C on bk docker --- bin/bk-docker | 1 + 1 file changed, 1 insertion(+) diff --git a/bin/bk-docker b/bin/bk-docker index 02fc3cb0..46af1062 100755 --- a/bin/bk-docker +++ b/bin/bk-docker @@ -72,6 +72,7 @@ exec docker run \ --name brewkit.pkgx.dev \ --rm \ $INTERACTIVE $PLATFORM \ + --init \ --volume "$d:/brewkit" \ --volume "$PKGX_PANTRY_PATH:/work" \ --volume "${XDG_CACHE_HOME:-$HOME/Library/Caches/pkgx}:/root/.cache/pkgx" \