fix(skaffold.yaml): read multi-doc skaffold.yaml and push all resolve all pkgs

Author: vkumbhar94

deno.json

@@ -11,7 +11,7 @@
     "include": ["src/"]
   },
   "imports": {
-    "libpkgx": "https://raw.githubusercontent.com/pkgxdev/libpkgx/refs/tags/v0.20.1/mod.ts",
+    "libpkgx": "https://raw.githubusercontent.com/pkgxdev/libpkgx/refs/tags/v0.21.0/mod.ts",
     "libpkgx/": "https://raw.githubusercontent.com/pkgxdev/libpkgx/refs/tags/v0.20.1/src/",
     "is-what": "https://deno.land/x/is_what@v4.1.15/src/index.ts",
     "outdent": "https://deno.land/x/outdent@v0.8.0/mod.ts"

deno.lock

@@ -0,0 +1,32 @@
+apiVersion: v4beta7
+kind: Config
+metadata:
+  name: skaffold-fixture
+build:
+  local:
+    useDockerCLI: true
+deploy:
+  kubeContext: minikube
+  docker:
+    images: []
+manifests:
+  kpt: []
+  kustomize: {}
+  helm:
+    releases: []
+
+profiles:
+  - name: skaffold-fixture
+---
+apiVersion: v4beta7
+kind: Config
+metadata:
+  name: skaffold-fixture
+deploy:
+  kubectl: {}
+  helm: {}
+manifests:
+  kustomize: {}
+
+profiles:
+  - name: skaffold-fixture

fixtures/skaffold.yaml/multidoc/skaffold.yaml

@@ -221,6 +221,16 @@ Deno.test("devenv.ts", async (runner) => {
           "kpt.dev",
           "kubernetes.io/kustomize",
         ],
+        [
+          "skaffold.yaml/multidoc/skaffold.yaml",
+          "skaffold.dev",
+          "kubernetes.io/kubectl",
+          "helm.sh",
+          "kpt.dev",
+          "kubernetes.io/minikube",
+          "docker.com/cli",
+          "kubernetes.io/kustomize",
+        ],
       ];
 
       for (const [keyfile, ...deps] of keyfiles) {

src/sniff.test.ts

@@ -260,46 +260,50 @@ export default async function (dir: Path) {
   }
 
   async function skaffold_yaml(path: Path) {
-    const yaml = await path.readYAML();
-    if (!isPlainObject(yaml)) return;
-    if (
-      yaml.build?.local?.useDockerCLI?.toString() === true ||
-      yaml.deploy?.docker
-    ) {
-      pkgs.push({
-        project: "docker.com/cli",
-        constraint: new semver.Range(`*`),
-      });
-    }
-    if (yaml.deploy?.kubectl) {
-      pkgs.push({
-        project: "kubernetes.io/kubectl",
-        constraint: new semver.Range(`*`),
-      });
-    }
-    if (yaml.deploy?.kubeContext?.match("minikube")) {
-      pkgs.push({
-        project: "kubernetes.io/minikube",
-        constraint: new semver.Range(`*`),
-      });
-    }
-    if (yaml.deploy?.helm || yaml.manifests?.helm) {
-      pkgs.push({
-        project: "helm.sh",
-        constraint: new semver.Range(`*`),
-      });
-    }
-    if (yaml.deploy?.kpt || yaml.manifests?.kpt) {
-      pkgs.push({
-        project: "kpt.dev",
-        constraint: new semver.Range(`*`),
-      });
-    }
-    if (yaml.manifests?.kustomize) {
-      pkgs.push({
-        project: "kubernetes.io/kustomize",
-        constraint: new semver.Range(`*`),
-      });
+    const yamls = await path.readYAMLAll() as unknown as any[];
+
+    for (const yaml of yamls) {
+      if (!isPlainObject(yaml)) continue;
+
+      if (
+          yaml.build?.local?.useDockerCLI?.toString() === "true" ||
+          yaml.deploy?.docker
+      ) {
+        pkgs.push({
+          project: "docker.com/cli",
+          constraint: new semver.Range(`*`),
+        });
+      }
+      if (yaml.deploy?.kubectl) {
+        pkgs.push({
+          project: "kubernetes.io/kubectl",
+          constraint: new semver.Range(`*`),
+        });
+      }
+      if (yaml.deploy?.kubeContext?.match("minikube")) {
+        pkgs.push({
+          project: "kubernetes.io/minikube",
+          constraint: new semver.Range(`*`),
+        });
+      }
+      if (yaml.deploy?.helm || yaml.manifests?.helm) {
+        pkgs.push({
+          project: "helm.sh",
+          constraint: new semver.Range(`*`),
+        });
+      }
+      if (yaml.deploy?.kpt || yaml.manifests?.kpt) {
+        pkgs.push({
+          project: "kpt.dev",
+          constraint: new semver.Range(`*`),
+        });
+      }
+      if (yaml.manifests?.kustomize) {
+        pkgs.push({
+          project: "kubernetes.io/kustomize",
+          constraint: new semver.Range(`*`),
+        });
+      }
     }
   }