Skip to content

Commit 324d29b

Browse files
committed
fix rollback
1 parent c9b5653 commit 324d29b

File tree

1 file changed

+33
-21
lines changed

1 file changed

+33
-21
lines changed

routes/apps.js

Lines changed: 33 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,7 @@ router.post('/:appName/deployments/:deploymentName/release',
288288
})
289289
.then((packages) => {
290290
if (packages) {
291-
Promise.delay(2000)
291+
Promise.delay(1000)
292292
.then(() => {
293293
packageManager.createDiffPackagesByLastNums(deploymentInfo.appid, packages, _.get(config, 'common.diffNums', 1))
294294
.catch((e) => {
@@ -403,15 +403,6 @@ router.post('/:appName/deployments/:sourceDeploymentName/promote/:destDeployment
403403
if (!destDeploymentInfo) {
404404
throw new AppError.AppError(`${destDeploymentName} does not exist.`);
405405
}
406-
//clear cache if exists.
407-
if (_.get(config, 'common.updateCheckCache', false) !== false) {
408-
Promise.delay(2500)
409-
.then(() => {
410-
var ClientManager = require('../core/services/client-manager');
411-
var clientManager = new ClientManager();
412-
clientManager.clearUpdateCheckCache(destDeploymentInfo.deployment_key, '*', '*', '*');
413-
});
414-
}
415406
return [sourceDeploymentInfo, destDeploymentInfo];
416407
})
417408
.spread((sourceDeploymentInfo, destDeploymentInfo) => {
@@ -421,14 +412,23 @@ router.post('/:appName/deployments/:sourceDeploymentName/promote/:destDeployment
421412
})
422413
.spread((packages, destDeploymentInfo) => {
423414
if (packages) {
424-
Promise.delay(2000)
415+
Promise.delay(1000)
425416
.then(() => {
426417
packageManager.createDiffPackagesByLastNums(destDeploymentInfo.appid, packages, _.get(config, 'common.diffNums', 1))
427418
.catch((e) => {
428419
log.error(e);
429420
});
430421
});
431422
}
423+
//clear cache if exists.
424+
if (_.get(config, 'common.updateCheckCache', false) !== false) {
425+
Promise.delay(2500)
426+
.then(() => {
427+
var ClientManager = require('../core/services/client-manager');
428+
var clientManager = new ClientManager();
429+
clientManager.clearUpdateCheckCache(destDeploymentInfo.deployment_key, '*', '*', '*');
430+
});
431+
}
432432
return packages;
433433
})
434434
})
@@ -456,16 +456,28 @@ var rollbackCb = function (req, res, next) {
456456
return deployments.findDeloymentByName(deploymentName, col.appid);
457457
})
458458
.then((dep) => {
459-
//clear cache if exists.
460-
if (_.get(config, 'common.updateCheckCache', false) !== false) {
461-
Promise.delay(2500)
462-
.then(() => {
463-
var ClientManager = require('../core/services/client-manager');
464-
var clientManager = new ClientManager();
465-
clientManager.clearUpdateCheckCache(dep.deployment_key, '*', '*', '*');
466-
});
467-
}
468-
return packageManager.rollbackPackage(dep.last_deployment_version_id, targetLabel, uid);
459+
return packageManager.rollbackPackage(dep.last_deployment_version_id, targetLabel, uid)
460+
.then((packageInfo)=>{
461+
if (packageInfo) {
462+
Promise.delay(1000)
463+
.then(() => {
464+
packageManager.createDiffPackagesByLastNums(dep.appid, packageInfo, 1)
465+
.catch((e) => {
466+
log.error(e);
467+
});
468+
});
469+
}
470+
//clear cache if exists.
471+
if (_.get(config, 'common.updateCheckCache', false) !== false) {
472+
Promise.delay(2500)
473+
.then(() => {
474+
var ClientManager = require('../core/services/client-manager');
475+
var clientManager = new ClientManager();
476+
clientManager.clearUpdateCheckCache(dep.deployment_key, '*', '*', '*');
477+
});
478+
}
479+
return packageInfo;
480+
});
469481
})
470482
.then(() => {
471483
res.send('ok');

0 commit comments

Comments
 (0)