Skip to content

Commit cc84da2

Browse files
authored
Merge pull request #3607 from plotly/fix/windows-build
Fix html build
2 parents ba5287c + 01d989a commit cc84da2

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.circleci/config.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,18 +158,18 @@ jobs:
158158
pip install --no-cache-dir --upgrade -e .[ci,dev] --progress-bar off
159159
- run:
160160
command: |
161-
nvm install 18 && nvm use 18
161+
nvm install 24 && nvm use 24
162162
- run:
163163
name: npm prereqs
164164
command: |
165-
nvm use 18
165+
nvm use 24
166166
npm ci
167167
cd dash/dash-renderer && npm i && cd ../../
168168
cd components/dash-html-components && npm i && npm run extract && cd ../../
169169
- run:
170170
name: ️️🏗️ build dash
171171
command: |
172-
nvm use 18
172+
nvm use 24
173173
. venv/Scripts/activate
174174
npm run private::build.jupyterlab && npm run private::build.renderer
175175
cd components/dash-html-components && npm run build

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# These owners will be the default owners for everything in
22
# the repo. Unless a later match takes precedence
3-
* @T4rk1n @ndrezn @gvwilson @emilykl
3+
* @T4rk1n @ndrezn @emilykl @camdecoster

components/dash-html-components/scripts/extract-elements.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,11 @@ function extractElements($) {
2222
// experimental, don't add yet
2323
'portal',
2424
'fencedframe',
25-
'selectedcontent'
25+
'selectedcontent',
26+
// Geolocation has a weird formatting catch
27+
`geolocation
28+
Experimental
29+
`
2630
];
2731
// `<section>` is for some reason missing from the reference tables.
2832
const addElements = [

0 commit comments

Comments
 (0)