From 20e5c5df93773d913151df3c2ae90b51c1269c98 Mon Sep 17 00:00:00 2001 From: philippe Date: Thu, 12 Feb 2026 09:44:15 -0500 Subject: [PATCH 1/5] try fix windows build --- .circleci/config.yml | 8 ++++---- components/dash-html-components/package.json | 2 ++ 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 17854f24d0..9b9ae62d6b 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -158,21 +158,21 @@ jobs: pip install --no-cache-dir --upgrade -e .[ci,dev] --progress-bar off - run: command: | - nvm install 18 && nvm use 18 + nvm install lts/iron && nvm use lts/iron - run: name: npm prereqs command: | - nvm use 18 + nvm use lts/iron npm ci cd dash/dash-renderer && npm i && cd ../../ cd components/dash-html-components && npm i && npm run extract && cd ../../ - run: name: ️️🏗️ build dash command: | - nvm use 18 + nvm use lts/iron . venv/Scripts/activate npm run private::build.jupyterlab && npm run private::build.renderer - cd components/dash-html-components && npm run build + cd components/dash-html-components && npm run build:windows no_output_timeout: 30m test-312: &test diff --git a/components/dash-html-components/package.json b/components/dash-html-components/package.json index 18710d53c2..26aca47057 100644 --- a/components/dash-html-components/package.json +++ b/components/dash-html-components/package.json @@ -19,9 +19,11 @@ "lint": "eslint src scripts", "build:js": "webpack --mode production", "build:backends": "dash-generate-components ./src/components dash_html_components -p package-info.json && cp dash_html_components_base/** dash_html_components && dash-generate-components ./src/components dash_html_components -p package-info.json --r-prefix 'html' --r-suggests 'dash,dashCoreComponents' --jl-prefix 'html' && black dash_html_components", + "build:py": "dash-generate-components ./src/components dash_html_components -p package-info.json && cp dash_html_components_base/** dash_html_components && dash-generate-components ./src/components dash_html_components -p package-info.json && black dash_html_components", "build": "npm run build:js && npm run build:backends", "postbuild": "es-check es5 dash_html_components/*.js", "build:watch": "watch 'npm run build' src", + "build:windows": "run-p build:js build:py", "test:py": "pytest --nopercyfinalize --headless tests/test_dash_html_components.py tests/test_integration.py", "test": "run-s -c test:py lint" }, From 2be7539245769f225596b38edc6a6f4c83c3225c Mon Sep 17 00:00:00 2001 From: philippe Date: Thu, 12 Feb 2026 10:21:47 -0500 Subject: [PATCH 2/5] try fix windows build --- .circleci/config.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 9b9ae62d6b..02fe0e90c4 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -158,18 +158,18 @@ jobs: pip install --no-cache-dir --upgrade -e .[ci,dev] --progress-bar off - run: command: | - nvm install lts/iron && nvm use lts/iron + nvm install 24 && nvm use 24 - run: name: npm prereqs command: | - nvm use lts/iron + nvm use 24 npm ci cd dash/dash-renderer && npm i && cd ../../ cd components/dash-html-components && npm i && npm run extract && cd ../../ - run: name: ️️🏗️ build dash command: | - nvm use lts/iron + nvm use 24 . venv/Scripts/activate npm run private::build.jupyterlab && npm run private::build.renderer cd components/dash-html-components && npm run build:windows From ed28717228b2639defb10d3a67827e20e8739ea2 Mon Sep 17 00:00:00 2001 From: philippe Date: Thu, 12 Feb 2026 11:57:40 -0500 Subject: [PATCH 3/5] try fix windows build --- components/dash-html-components/package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/dash-html-components/package.json b/components/dash-html-components/package.json index 26aca47057..4840d76742 100644 --- a/components/dash-html-components/package.json +++ b/components/dash-html-components/package.json @@ -19,11 +19,11 @@ "lint": "eslint src scripts", "build:js": "webpack --mode production", "build:backends": "dash-generate-components ./src/components dash_html_components -p package-info.json && cp dash_html_components_base/** dash_html_components && dash-generate-components ./src/components dash_html_components -p package-info.json --r-prefix 'html' --r-suggests 'dash,dashCoreComponents' --jl-prefix 'html' && black dash_html_components", - "build:py": "dash-generate-components ./src/components dash_html_components -p package-info.json && cp dash_html_components_base/** dash_html_components && dash-generate-components ./src/components dash_html_components -p package-info.json && black dash_html_components", + "build:py": "dash-generate-components ./src/components dash_html_components -p package-info.json && cp dash_html_components_base/** dash_html_components && dash-generate-components ./src/components dash_html_components -p package-info.json && black dash_html_components", "build": "npm run build:js && npm run build:backends", "postbuild": "es-check es5 dash_html_components/*.js", "build:watch": "watch 'npm run build' src", - "build:windows": "run-p build:js build:py", + "build:windows": "npm run build:js && build:py", "test:py": "pytest --nopercyfinalize --headless tests/test_dash_html_components.py tests/test_integration.py", "test": "run-s -c test:py lint" }, From 8118d54e66baa8b408c4edeaed0e8aa2064a58ac Mon Sep 17 00:00:00 2001 From: philippe Date: Thu, 12 Feb 2026 12:13:10 -0500 Subject: [PATCH 4/5] fix html build --- .circleci/config.yml | 2 +- components/dash-html-components/package.json | 2 -- components/dash-html-components/scripts/extract-elements.js | 6 +++++- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index 02fe0e90c4..4406430e7c 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -172,7 +172,7 @@ jobs: nvm use 24 . venv/Scripts/activate npm run private::build.jupyterlab && npm run private::build.renderer - cd components/dash-html-components && npm run build:windows + cd components/dash-html-components && npm run build no_output_timeout: 30m test-312: &test diff --git a/components/dash-html-components/package.json b/components/dash-html-components/package.json index 4840d76742..18710d53c2 100644 --- a/components/dash-html-components/package.json +++ b/components/dash-html-components/package.json @@ -19,11 +19,9 @@ "lint": "eslint src scripts", "build:js": "webpack --mode production", "build:backends": "dash-generate-components ./src/components dash_html_components -p package-info.json && cp dash_html_components_base/** dash_html_components && dash-generate-components ./src/components dash_html_components -p package-info.json --r-prefix 'html' --r-suggests 'dash,dashCoreComponents' --jl-prefix 'html' && black dash_html_components", - "build:py": "dash-generate-components ./src/components dash_html_components -p package-info.json && cp dash_html_components_base/** dash_html_components && dash-generate-components ./src/components dash_html_components -p package-info.json && black dash_html_components", "build": "npm run build:js && npm run build:backends", "postbuild": "es-check es5 dash_html_components/*.js", "build:watch": "watch 'npm run build' src", - "build:windows": "npm run build:js && build:py", "test:py": "pytest --nopercyfinalize --headless tests/test_dash_html_components.py tests/test_integration.py", "test": "run-s -c test:py lint" }, diff --git a/components/dash-html-components/scripts/extract-elements.js b/components/dash-html-components/scripts/extract-elements.js index 41bfba619a..c1d879029f 100644 --- a/components/dash-html-components/scripts/extract-elements.js +++ b/components/dash-html-components/scripts/extract-elements.js @@ -22,7 +22,11 @@ function extractElements($) { // experimental, don't add yet 'portal', 'fencedframe', - 'selectedcontent' + 'selectedcontent', + // Geolocation has a weird formatting catch + `geolocation +Experimental +` ]; // `
` is for some reason missing from the reference tables. const addElements = [ From 01d989aa55de712b55721adfda3feb293527408a Mon Sep 17 00:00:00 2001 From: philippe Date: Thu, 12 Feb 2026 13:16:14 -0500 Subject: [PATCH 5/5] update codeowners --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index f5b2045edc..167ecd988e 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,3 +1,3 @@ # These owners will be the default owners for everything in # the repo. Unless a later match takes precedence -* @T4rk1n @ndrezn @gvwilson @emilykl +* @T4rk1n @ndrezn @emilykl @camdecoster