test hoveron in supplyDefaults

Author: alexcjohnson

test/jasmine/tests/scatter_test.js

@@ -60,6 +60,39 @@ describe('Test scatter', function() {
             expect(traceOut.visible).toBe(false);
         });
 
+        it('should correctly assign \'hoveron\' default', function() {
+            traceIn = {
+                x: [1, 2, 3],
+                y: [1, 2, 3],
+                mode: 'lines+markers',
+                fill: 'tonext'
+            };
+
+            // even with fill tonext, as long as there are markers or text
+            // you get points
+            // you need visible: true here, as that normally gets set
+            // outside of the module supplyDefaults
+            traceOut = {visible: true};
+            supplyDefaults(traceIn, traceOut, defaultColor, layout);
+            expect(traceOut.hoveron).toBe('points');
+
+            // but with only lines (or just fill) and fill tonext or toself
+            // you get fills
+            traceIn.mode = 'lines';
+            traceOut = {visible: true};
+            supplyDefaults(traceIn, traceOut, defaultColor, layout);
+            expect(traceOut.hoveron).toBe('fills');
+
+            // with the wrong fill you always get points
+            // only area fills default to hoveron points. Vertical or
+            // horizontal fills don't have the same physical meaning,
+            // they're generally just filling their own slice, so they
+            // default to hoveron points.
+            traceIn.fill = 'tonexty';
+            traceOut = {visible: true};
+            supplyDefaults(traceIn, traceOut, defaultColor, layout);
+            expect(traceOut.hoveron).toBe('points');
+        });
     });
 
     describe('isBubble', function() {

test/jasmine/tests/scatterternary_test.js

@@ -158,6 +158,40 @@ describe('scatterternary defaults', function() {
         supplyDefaults(traceIn, traceOut, defaultColor, layout);
         expect(traceOut.hoverinfo).toBe('a+b+c+text');
     });
+
+    it('should correctly assign \'hoveron\' default', function() {
+        traceIn = {
+            a: [1, 2, 3],
+            b: [1, 2, 3],
+            c: [1, 2, 3],
+            mode: 'lines+markers',
+            fill: 'tonext'
+        };
+
+        // even with fill tonext, as long as there are markers or text
+        // you get points
+        // you need visible: true here, as that normally gets set
+        // outside of the module supplyDefaults
+        traceOut = {visible: true};
+        supplyDefaults(traceIn, traceOut, defaultColor, layout);
+        expect(traceOut.hoveron).toBe('points');
+
+        // but with only lines (or just fill) and fill tonext or toself
+        // you get fills
+        traceIn.mode = 'lines';
+        traceOut = {visible: true};
+        supplyDefaults(traceIn, traceOut, defaultColor, layout);
+        expect(traceOut.hoveron).toBe('fills');
+
+        // without a fill you always get points. For scatterternary, unlike
+        // scatter, every allowed fill but 'none' is an area fill (rather than
+        // a vertical / horizontal fill) so they all should default to
+        // hoveron points.
+        traceIn.fill = 'none';
+        traceOut = {visible: true};
+        supplyDefaults(traceIn, traceOut, defaultColor, layout);
+        expect(traceOut.hoveron).toBe('points');
+    });
 });
 
 describe('scatterternary calc', function() {