don't coerce 'stepmode' and 'count' when 'step' is set to 'all'

Author: etpinard

src/components/rangeselector/defaults.js

@@ -55,9 +55,12 @@ function buttonsDefaults(containerIn, containerOut) {
         buttonIn = buttonsIn[i];
         buttonOut = {};
 
-        coerce('step');
-        coerce('stepmode');
-        coerce('count');
+        var step = coerce('step');
+        if(step !== 'all') {
+            coerce('stepmode');
+            coerce('count');
+        }
+
         coerce('label');
 
         buttonsOut.push(buttonOut);

test/jasmine/tests/range_selector_test.js

@@ -2,10 +2,11 @@ var RangeSelector = require('@src/components/rangeselector');
 var getUpdateObject = require('@src/components/rangeselector/get_update_object');
 
 
-describe('range selector', function() {
+
+describe('[range selector suite]', function() {
     'use strict';
 
-    describe('defaults', function() {
+    describe('defaults:', function() {
         var supplyLayoutDefaults = RangeSelector.supplyLayoutDefaults;
 
         it('should set \'visible\' to false when no buttons are present', function() {
@@ -21,6 +22,24 @@ describe('range selector', function() {
                 });
         });
 
+        it('should coerce an empty button object', function() {
+            var containerIn = {
+                rangeselector: {
+                    buttons: [{}]
+                }
+            };
+            var containerOut = {};
+
+            supplyLayoutDefaults(containerIn, containerOut, {});
+
+            expect(containerIn.rangeselector.buttons).toEqual([{}]);
+            expect(containerOut.rangeselector.buttons).toEqual([{
+                step: 'month',
+                stepmode: 'backward',
+                count: 1
+            }]);
+        });
+
         it('should coerce all buttons present', function() {
             var containerIn = {
                 rangeselector: {
@@ -43,6 +62,25 @@ describe('range selector', function() {
             ]);
         });
 
+        it('should not coerce \'stepmode\' and \'count\', for \'step\' all buttons', function() {
+            var containerIn = {
+                rangeselector: {
+                    buttons: [{
+                        step: 'all',
+                        label: 'full range'
+                    }]
+                }
+            };
+            var containerOut = {};
+
+            supplyLayoutDefaults(containerIn, containerOut, {});
+
+            expect(containerOut.rangeselector.buttons).toEqual([{
+                step: 'all',
+                label: 'full range'
+            }]);
+        });
+
     });
 
     describe('getUpdateObject', function() {