resolve feedback

Addresses phpstan#3613 (comment)

Author: pmjones

src/Type/Php/ExplodeFunctionDynamicReturnTypeExtension.php

@@ -58,12 +58,17 @@ public function getTypeFromFunctionCall(
 		}
 
 		$stringType = $scope->getType($args[1]->value);
+		$accessory = [];
 		if ($stringType->isLowercaseString()->yes()) {
-			$returnValueType = new IntersectionType([new StringType(), new AccessoryLowercaseStringType()]);
-		} elseif ($stringType->isUppercaseString()->yes()) {
-			$returnValueType = new IntersectionType([new StringType(), new AccessoryUppercaseStringType()]);
+		    $accessory[] = new AccessoryLowercaseStringType();
+		}
+		if ($stringType->isUppercaseString()->yes()) {
+		    $accessory[] = new AccessoryUppercaseStringType();
+		}
+		if (count($accessory) > 0) {
+		    $returnValueType = new IntersectionType([new StringType(), ...$accessory]);
 		} else {
-			$returnValueType = new StringType();
+		    $returnValueType = new StringType();
 		}
 
 		$returnType = AccessoryArrayListType::intersectWith(new ArrayType(new IntegerType(), $returnValueType));

tests/PHPStan/Analyser/LegacyNodeScopeResolverTest.php

@@ -1129,19 +1129,19 @@ public function dataArrayDestructuring(): array
 				'$fourthStringArrayForeachList',
 			],
 			[
-				'lowercase-string',
+				'lowercase-string&uppercase-string',
 				'$dateArray[\'Y\']',
 			],
 			[
-				'lowercase-string',
+				'lowercase-string&uppercase-string',
 				'$dateArray[\'m\']',
 			],
 			[
 				'int',
 				'$dateArray[\'d\']',
 			],
 			[
-				'lowercase-string',
+				'lowercase-string&uppercase-string',
 				'$intArrayForRewritingFirstElement[0]',
 			],
 			[

tests/PHPStan/Analyser/nsrt/bug-4711.php

@@ -12,8 +12,8 @@ function x(string $string): void {
 			return;
 		}
 
-		assertType('non-empty-list<lowercase-string>', explode($string, ''));
-		assertType('non-empty-list<lowercase-string>', explode($string[0], ''));
+		assertType('non-empty-list<lowercase-string&uppercase-string>', explode($string, ''));
+		assertType('non-empty-list<lowercase-string&uppercase-string>', explode($string[0], ''));
 	}
 
 }