You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Apologies for the unsolicited fwiw @porsager 😅 ... but fwiw would love to have you reconsider TypeScript & in-source comments for the next version of postgres.js.
Reading the code today, I can tell each line is crafted to be as elegant & succinct as possible--you obviously care a lot about the current style of readability / brevity / etc.
But, for me, as an occasional patcher/forker, it makes the codebase fairly intimidating/opaque in terms of how/why things work the way they do.
Granted, I get performance is paramount for postgres.js, and a con of certain TypeScript features is ~obtuse/slow output--but I'd like to think that a strict subset of features would avoid this. 🤞
But, besides just types/TypeScript, the brevity spreading into "basically no in-source comments / documentation / rationale" also imo hurts maintainability/collaboration. I'm sure the trade-offs / rationale / perf tweaks you've made to achieve the current amazing results are all cemented in your head -- but they're not yet in anyone else's head.
Final disclaimer, you ofc do not "owe us/users" anything, & it's perfectly fine to keep your current style/approach/etc -- obviously you're doing something write with the current perf & adoption 💯 -- but I've just had this ask in my head for awhile, and wanted to get it typed out. Np either way. Thank you!
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
Apologies for the unsolicited fwiw @porsager 😅 ... but fwiw would love to have you reconsider TypeScript & in-source comments for the next version of postgres.js.
Reading the code today, I can tell each line is crafted to be as elegant & succinct as possible--you obviously care a lot about the current style of readability / brevity / etc.
But, for me, as an occasional patcher/forker, it makes the codebase fairly intimidating/opaque in terms of how/why things work the way they do.
Granted, I get performance is paramount for postgres.js, and a con of certain TypeScript features is ~obtuse/slow output--but I'd like to think that a strict subset of features would avoid this. 🤞
But, besides just types/TypeScript, the brevity spreading into "basically no in-source comments / documentation / rationale" also imo hurts maintainability/collaboration. I'm sure the trade-offs / rationale / perf tweaks you've made to achieve the current amazing results are all cemented in your head -- but they're not yet in anyone else's head.
Final disclaimer, you ofc do not "owe us/users" anything, & it's perfectly fine to keep your current style/approach/etc -- obviously you're doing something write with the current perf & adoption 💯 -- but I've just had this ask in my head for awhile, and wanted to get it typed out. Np either way. Thank you!
Beta Was this translation helpful? Give feedback.
All reactions