Merge pull request #687 from postmanlabs/feature/fix-backslash-escape

Don't escape backslash in raw bodies

Author: Ankit Saini

codegens/curl/lib/index.js

@@ -141,7 +141,8 @@ self = module.exports = {
               isAsperandPresent = _.includes(rawBody, '@'),
               // Use the long option if `@` is present in the request body otherwise follow user setting
               optionName = isAsperandPresent ? '--data-raw' : form('-d', format);
-            snippet += indent + `${optionName} ${quoteType}${sanitize(rawBody, trim, quoteType, true)}${quoteType}`;
+            // eslint-disable-next-line max-len
+            snippet += indent + `${optionName} ${quoteType}${sanitize(rawBody, trim, quoteType)}${quoteType}`;
             break;
           }
 

codegens/curl/test/unit/convert.test.js

@@ -34,41 +34,6 @@ describe('curl convert function', function () {
       });
     });
 
-    it('should escape backslash in raw bodies', function () {
-      request = new sdk.Request({
-        'method': 'POST',
-        'header': [
-          {
-            'key': 'Content-Type',
-            'value': 'application/json'
-          }
-        ],
-        'body': {
-          'mode': 'raw',
-          'raw': '{ "foo": "\\" }'
-        },
-        'url': {
-          'raw': 'https://postman-echo.com/post',
-          'protocol': 'https',
-          'host': [
-            'postman-echo',
-            'com'
-          ],
-          'path': [
-            'post'
-          ]
-        }
-      });
-
-      convert(request, {}, function (error, snippet) {
-        if (error) {
-          expect.fail(null, null, error);
-        }
-
-        expect(snippet).to.contain('{ "foo": "\\\\" }');
-      });
-    });
-
     it('should return snippet with url in single quote(\')', function () {
       request = new sdk.Request({
         'method': 'POST',

codegens/r-httr/test/newman/newman.test.js

@@ -13,7 +13,7 @@ describe('r-httr Converter', function () {
         fileName: 'snippet.r',
         // Run script required to run the generated code snippet
         runScript: 'Rscript snippet.r',
-        skipCollections: ['redirectCollection', 'unsupportedMethods']
+        skipCollections: ['redirectCollection', 'unsupportedMethods', 'rawBody']
       };
     runNewmanTest(convert, options, testConfig);
   });

test/codegen/newman/fixtures/rawBody.json

@@ -0,0 +1,39 @@
+{
+	"info": {
+		"_postman_id": "f52ee07d-6345-4220-89af-e6696b3c0122",
+		"name": "Basic Collection",
+		"description": "This collection contains requests that will be used to test validity of plugin created to convert postman request into code snippet of particular language.",
+		"schema": "https://schema.getpostman.com/json/collection/v2.1.0/collection.json"
+	},
+	"item": [
+		{
+			"name": "POST raw with quoted text",
+			"event": [],
+			"request": {
+				"method": "POST",
+				"header": [
+					{
+						"key": "Content-Type",
+						"value": "application/json"
+					}
+				],
+				"body": {
+					"mode": "raw",
+					"raw": "{\n    \"Hello\": \"{\\\"hello_world\\\": true}\"\n}"
+				},
+				"url": {
+					"raw": "https://postman-echo.com/post",
+					"protocol": "https",
+					"host": [
+						"postman-echo",
+						"com"
+					],
+					"path": [
+						"post"
+					]
+				}
+			},
+			"response": []
+		}
+  ]
+}