Skip to content

Commit 669c25a

Browse files
authored
fix: update the DESCRIPTION file and the R doc according last submission (#195)
1 parent 9666c0d commit 669c25a

File tree

9 files changed

+98
-35
lines changed

9 files changed

+98
-35
lines changed

DESCRIPTION

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
Package: bpmnVisualizationR
22
Type: Package
3-
Title: Visualize Process Execution Data on BPMN Diagrams
3+
Title: Visualize Process Execution Data on 'BPMN' Diagrams
44
Version: 0.3.1.9000
55
Authors@R: c(person("Celine", "Souchet", role = c("aut", "cre"), email = "process.analytics.dev+CRAN@gmail.com"),
66
person("Thomas", "Bouffard", role = "aut"))
7-
Description: To visualize the execution data of the processes on BPMN (Business Process Model and Notation) diagrams, using overlays, style customization and interactions, with the bpmn-visualization TypeScript library.
7+
Description: To visualize the execution data of the processes on 'BPMN' (Business Process Model and Notation) diagrams, using overlays, style customization and interactions, with the 'bpmn-visualization' 'TypeScript' library.
88
License: Apache License (== 2)
99
Copyright: Bonitasoft S.A.
1010
URL: https://process-analytics.github.io/bpmn-visualization-R/, https://github.com/process-analytics/bpmn-visualization-R/

R/bpmnVisualizationR.R

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -12,23 +12,23 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
#' @title Display BPMN diagram in an HTML Widget
15+
#' @title Display 'BPMN' diagram in an 'HTML' Widget
1616
#'
1717
#' @name display
18-
#' @description Display BPMN diagram based on BPMN definition in XML format
18+
#' @description Display 'BPMN' diagram based on 'BPMN' definition in 'XML' format
1919
#'
20-
#' @param bpmnXML A file name or xml document or string in BPMN XML format
20+
#' @param bpmnXML A file name or 'XML' document or string in 'BPMN' 'XML' format
2121
#' @param overlays An element or a list of elements to be added to the diagram's existing elements.
2222
#' Use overlay function to create an overlay object with content and relative position.
2323
#' @param width Fixed width for widget (in css units). The default is \code{NULL}, which results in intelligent automatic sizing based on the widget's container.
2424
#' @param height Fixed height for widget (in css units). The default is \code{NULL}, which results in intelligent automatic sizing based on the widget's container.
25-
#' @param elementId The id of the HTML element to enclose the widget.
25+
#' @param elementId The id of the 'HTML' element to enclose the widget.
2626
#' Use an explicit element ID for the widget (rather than an automatically
27-
#' generated one). Useful if you have other JavaScript that needs to explicitly
27+
#' generated one). Useful if you have other 'JavaScript' that needs to explicitly
2828
#' discover and interact with a specific widget instance.
2929
#'
30-
#' @returns A \code{bpmnVisualizationR} Widget that will intelligently print itself into HTML in a variety of contexts
31-
#' including the R console, within R Markdown documents, and within Shiny output bindings.
30+
#' @returns A \code{bpmnVisualizationR} Widget that will intelligently print itself into 'HTML' in a variety of contexts
31+
#' including the 'R' console, within 'R Markdown' documents, and within 'Shiny' output bindings.
3232
#'
3333
#' @examples
3434
#' # Load the BPMN file
@@ -73,18 +73,18 @@ display <- function(
7373
)
7474
}
7575

76-
#' @title Shiny output binding for the \code{bpmnVisualizationR} HTML widget
76+
#' @title Shiny output binding for the \code{bpmnVisualizationR} 'HTML' widget
7777
#'
7878
#' @name bpmnVisualizationR-shiny-output
7979
#' @description
80-
#' Helper to create output function for using the \code{bpmnVisualizationR} HTML widget within Shiny applications and interactive Rmd documents.
80+
#' Helper to create output function for using the \code{bpmnVisualizationR} 'HTML' widget within 'Shiny' applications and interactive 'Rmd' documents.
8181
#'
8282
#' @param outputId output variable to read from
8383
#' @param width,height Must be a valid CSS unit (like \code{'100\%'},
8484
#' \code{'400px'}, \code{'auto'}) or a number, which will be coerced to a
8585
#' string and have \code{'px'} appended.
8686
#'
87-
#' @returns An output function that enables the use of the \code{bpmnVisualizationR} widget within Shiny applications.
87+
#' @returns An output function that enables the use of the \code{bpmnVisualizationR} widget within 'Shiny' applications.
8888
#'
8989
#' @export
9090
bpmnVisualizationROutput <- function(
@@ -101,18 +101,18 @@ bpmnVisualizationROutput <- function(
101101
)
102102
}
103103

104-
#' @title Shiny render binding for the \code{bpmnVisualizationR} HTML widget
104+
#' @title 'Shiny' render binding for the \code{bpmnVisualizationR} 'HTML' widget
105105
#'
106106
#' @rdname bpmnVisualizationR-shiny-render
107107
#' @description
108-
#' Helper to create render function for using the \code{bpmnVisualizationR} HTML widget within Shiny applications and interactive Rmd documents.
108+
#' Helper to create render function for using the \code{bpmnVisualizationR} 'HTML' widget within 'Shiny' applications and interactive 'Rmd' documents.
109109
#'
110-
#' @param expr An expression that generates a \code{bpmnVisualizationR} HTML widget
110+
#' @param expr An expression that generates a \code{bpmnVisualizationR} 'HTML' widget
111111
#' @param env The environment in which to evaluate \code{expr}.
112112
#' @param quoted Is \code{expr} a quoted expression (with \code{quote()})? This
113113
#' is useful if you want to save an expression in a variable.
114114
#'
115-
#' @returns A render function that enables the use of the \code{bpmnVisualizationR} widget within Shiny applications.
115+
#' @returns A render function that enables the use of the \code{bpmnVisualizationR} widget within 'Shiny' applications.
116116
#'
117117
#' @export
118118
renderBpmnVisualizationR <- function(

R/funs.R

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
#' Use this structure to create correct overlay structure.
1010
#'
1111
#' @param elementId The bpmn element id to which the overlay will be attached
12-
#' @param label HTML element to use as an overlay
12+
#' @param label 'HTML' element to use as an overlay
1313
#'
1414
#' @returns An overlay object
1515
#'
@@ -22,7 +22,7 @@ create_overlay <- function(elementId, label) {
2222
)
2323
}
2424

25-
#' @description Internal fun to build the htmlwidget content
25+
#' @description Internal fun to build the 'htmlwidget' content
2626
#'
2727
#' @inheritParams display
2828
#' @returns A list

cran-comments.md

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,66 @@
1+
# bpmnVisualizationR 0.3.1.9000
2+
3+
This is a new submission. In this version, we have:
4+
5+
* Added single quotes for package names, software names and API, in `title` and `description` on the [DESCRIPTION](DESCRIPTION) file.
6+
* Added single quotes for package names, software names and API, in the documentation of the methods of this package.
7+
8+
## Test environments
9+
10+
- R-hub windows-x86_64-devel (r-devel). Platform: Windows Server 2022, R-devel, 64 bit
11+
- R-hub ubuntu-gcc-release (r-release). Platform: Ubuntu Linux 20.04.1 LTS, R-release, GCC
12+
- R-hub fedora-clang-devel (r-devel). Platform: Fedora Linux, R-devel, clang, gfortran
13+
14+
## R CMD check results
15+
16+
There were no ERRORs or WARNINGs.
17+
18+
As noted in [R-hub issue #503](https://github.com/r-hub/rhub/issues/503), this could be due to a bug/crash in MiKTeX and can likely be ignored.
19+
Also, we cannot change that `Tidy` is not on the path or update `Tidy` on the external Fedora Linux server.
20+
21+
❯ On windows-x86_64-devel (r-devel), ubuntu-gcc-release (r-release)
22+
checking CRAN incoming feasibility ... NOTE
23+
Maintainer: 'Celine Souchet <process.analytics.dev+CRAN@gmail.com>'
24+
25+
New submission
26+
27+
❯ On windows-x86_64-devel (r-devel)
28+
checking for detritus in the temp directory ... NOTE
29+
Found the following files/directories:
30+
'lastMiKTeXException'
31+
32+
❯ On fedora-clang-devel (r-devel)
33+
checking CRAN incoming feasibility ... [6s/25s] NOTE
34+
Maintainer: ‘Celine Souchet <process.analytics.dev+CRAN@gmail.com>’
35+
36+
New submission
37+
38+
❯ On fedora-clang-devel (r-devel)
39+
checking HTML version of manual ... NOTE
40+
Skipping checking HTML validation: no command 'tidy' found
41+
42+
0 errors ✔ | 0 warnings ✔ | 4 notes ✖
43+
44+
## Response to CRAN for last submission
45+
46+
> If there are references describing the methods in your package, please
47+
> add these in the description field of your DESCRIPTION file in the form
48+
> authors (year) <doi:...>
49+
> authors (year) <arXiv:...>
50+
> authors (year, ISBN:...)
51+
> or if those are not available: <https:...>
52+
> with no space after 'doi:', 'arXiv:', 'https:' and angle brackets for
53+
> auto-linking. (If you want to add a title as well please put it in quotes: "Title")
54+
55+
There is no reference describing the methods in this package.
56+
57+
> Please always write package names, software names and API (application
58+
> programming interface) names in single quotes in title and description.
59+
> e.g: --> 'TypeScript'
60+
> Please note that package names are case-sensitive.
61+
62+
✅ Done on the [DESCRIPTION](DESCRIPTION) file and the documentation of the methods of this package.
63+
164
# bpmnVisualizationR 0.3.1
265

366
This is a new submission. In this version, we have:

man/bpmnVisualizationR-package.Rd

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/bpmnVisualizationR-shiny-output.Rd

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/bpmnVisualizationR-shiny-render.Rd

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/create_overlay.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/display.Rd

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)