From 6763e4bd75106de4b0a75985e8f00823a97850a2 Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Thu, 18 Sep 2025 17:00:56 +0200 Subject: [PATCH 1/2] test(e2e): increase some chrome thresholds The Chrome browser installed on GH Actions runner has been recently updated, so adjust some thresholds. --- test/e2e/bpmn.elements.collapsed.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/bpmn.elements.collapsed.test.ts b/test/e2e/bpmn.elements.collapsed.test.ts index 130bd48fa4..23afeb9972 100644 --- a/test/e2e/bpmn.elements.collapsed.test.ts +++ b/test/e2e/bpmn.elements.collapsed.test.ts @@ -45,7 +45,7 @@ const getElementsToCollapse = (bpmnDiagramName: string): string[] => { describe('Collapse BPMN elements', () => { const diagramSubfolder = 'collapse-expand'; const imageSnapshotConfigurator = new CollapsedElementImageSnapshotConfigurator( - // chromium: max 0.1645741693097058% + // chromium: max 0.1645741693097058% - TODO increase max seems to be 0.17189816618451426% // firefox: max 0.1218238557421536% // webkit: max 0.14363687914162873% new MultiBrowserImageSnapshotThresholds({ chromium: 0.17 / 100, firefox: 0.13 / 100, webkit: 0.15 / 100 }), From 858e1ddc64db58ad862621b0d162d8560c81be7d Mon Sep 17 00:00:00 2001 From: Thomas Bouffard <27200110+tbouffard@users.noreply.github.com> Date: Thu, 18 Sep 2025 18:40:04 +0200 Subject: [PATCH 2/2] update threshold for chromium (for chrome on macos) --- test/e2e/bpmn.elements.collapsed.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/e2e/bpmn.elements.collapsed.test.ts b/test/e2e/bpmn.elements.collapsed.test.ts index 23afeb9972..59ae89a122 100644 --- a/test/e2e/bpmn.elements.collapsed.test.ts +++ b/test/e2e/bpmn.elements.collapsed.test.ts @@ -45,10 +45,10 @@ const getElementsToCollapse = (bpmnDiagramName: string): string[] => { describe('Collapse BPMN elements', () => { const diagramSubfolder = 'collapse-expand'; const imageSnapshotConfigurator = new CollapsedElementImageSnapshotConfigurator( - // chromium: max 0.1645741693097058% - TODO increase max seems to be 0.17189816618451426% + // chromium (including chrome): max 0.17189816618451426% // firefox: max 0.1218238557421536% // webkit: max 0.14363687914162873% - new MultiBrowserImageSnapshotThresholds({ chromium: 0.17 / 100, firefox: 0.13 / 100, webkit: 0.15 / 100 }), + new MultiBrowserImageSnapshotThresholds({ chromium: 0.18 / 100, firefox: 0.13 / 100, webkit: 0.15 / 100 }), diagramSubfolder, ); const pageTester = new PageTester({ targetedPage: AvailableTestPages.BPMN_RENDERING, diagramSubfolder }, page);