Skip to content

Commit 79a7229

Browse files
committed
Fixes differences from main
1 parent ff6fdb3 commit 79a7229

File tree

8 files changed

+77
-62
lines changed

8 files changed

+77
-62
lines changed

app/build.gradle.kts

Lines changed: 58 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -51,27 +51,65 @@ compose.desktop {
5151
application {
5252
mainClass = "processing.app.ProcessingKt"
5353

54-
jvmArgs(*listOf(
54+
jvmArgs(
55+
*listOf(
5556
Pair("processing.version", rootProject.version),
5657
Pair("processing.revision", findProperty("revision") ?: Int.MAX_VALUE),
5758
Pair("processing.contributions.source", "https://contributions.processing.org/contribs"),
5859
Pair("processing.download.page", "https://processing.org/download/"),
5960
Pair("processing.download.latest", "https://processing.org/download/latest.txt"),
6061
Pair("processing.tutorials", "https://processing.org/tutorials/"),
61-
).map { "-D${it.first}=${it.second}" }.toTypedArray())
62+
).map { "-D${it.first}=${it.second}" }.toTypedArray()
63+
)
6264

6365
nativeDistributions{
64-
modules("jdk.jdi", "java.compiler", "jdk.accessibility", "jdk.zipfs", "java.management.rmi", "java.scripting", "jdk.httpserver")
66+
modules(
67+
"jdk.jdi",
68+
"java.compiler",
69+
"jdk.accessibility",
70+
"jdk.zipfs",
71+
"java.management.rmi",
72+
"java.scripting",
73+
"jdk.httpserver"
74+
)
6575
targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb)
6676
packageName = "Processing"
6777

6878

6979

7080

71-
fileAssociation("application/x-processing","pde", "Processing Source Code",rootProject.file("build/shared/lib/icons/pde-512.png"), rootProject.file("build/windows/pde.ico"), rootProject.file("build/macos/pde.icns"))
72-
fileAssociation("application/x-processing","pyde", "Processing Python Source Code",rootProject.file("build/shared/lib/icons/pde-512.png"), rootProject.file("build/windows/pde.ico"), rootProject.file("build/macos/pde.icns"))
73-
fileAssociation("application/x-processing","pdez", "Processing Sketch Bundle",rootProject.file("build/shared/lib/icons/pde-512.png"), rootProject.file("build/windows/pdze.ico"), rootProject.file("build/macos/pdez.icns"))
74-
fileAssociation("application/x-processing","pdex", "Processing Contribution Bundle", rootProject.file("build/shared/lib/icons/pde-512.png"), rootProject.file("build/windows/pdex.ico"), rootProject.file("build/macos/pdex.icns"))
81+
fileAssociation(
82+
"application/x-processing",
83+
"pde",
84+
"Processing Source Code",
85+
rootProject.file("build/shared/lib/icons/pde-512.png"),
86+
rootProject.file("build/windows/pde.ico"),
87+
rootProject.file("build/macos/pde.icns")
88+
)
89+
fileAssociation(
90+
"application/x-processing",
91+
"pyde",
92+
"Processing Python Source Code",
93+
rootProject.file("build/shared/lib/icons/pde-512.png"),
94+
rootProject.file("build/windows/pde.ico"),
95+
rootProject.file("build/macos/pde.icns")
96+
)
97+
fileAssociation(
98+
"application/x-processing",
99+
"pdez",
100+
"Processing Sketch Bundle",
101+
rootProject.file("build/shared/lib/icons/pde-512.png"),
102+
rootProject.file("build/windows/pdze.ico"),
103+
rootProject.file("build/macos/pdez.icns")
104+
)
105+
fileAssociation(
106+
"application/x-processing",
107+
"pdex",
108+
"Processing Contribution Bundle",
109+
rootProject.file("build/shared/lib/icons/pde-512.png"),
110+
rootProject.file("build/windows/pdex.ico"),
111+
rootProject.file("build/macos/pdex.icns")
112+
)
75113

76114
macOS{
77115
bundleID = "${rootProject.group}.app"
@@ -267,7 +305,7 @@ tasks.register("generateSnapConfiguration"){
267305
)
268306
}
269307
}
270-
tasks.register("generateFlatpakConfiguration"){
308+
tasks.register("generateFlatpakConfiguration") {
271309
val identifier = findProperty("flathubidentifier") as String? ?: "org.processing.pde"
272310

273311
val dir = distributable().destinationDir.get()
@@ -291,7 +329,7 @@ fun replaceVariablesInFile(
291329
target: RegularFile,
292330
variables: Map<String, String>,
293331
sections: List<String>
294-
){
332+
) {
295333
var content = source.asFile.readText()
296334
for ((key, value) in variables) {
297335
content = content.replace("\$$key", value)
@@ -320,7 +358,7 @@ tasks.register<Exec>("packageSnap"){
320358
commandLine("snapcraft")
321359
}
322360

323-
tasks.register<Exec>("buildFlatpak"){
361+
tasks.register<Exec>("buildFlatpak") {
324362
onlyIf { OperatingSystem.current().isLinux }
325363
dependsOn("generateFlatpakConfiguration")
326364
group = "compose desktop"
@@ -340,7 +378,7 @@ tasks.register<Exec>("buildFlatpak"){
340378
)
341379
}
342380

343-
tasks.register<Exec>("packageFlatpak"){
381+
tasks.register<Exec>("packageFlatpak") {
344382
onlyIf { OperatingSystem.current().isLinux }
345383
dependsOn("buildFlatpak")
346384
group = "compose desktop"
@@ -470,7 +508,7 @@ tasks.register<Copy>("includeJavaModeResources") {
470508
}
471509
// TODO: Move to java mode
472510
tasks.register<Copy>("renameWindres") {
473-
dependsOn("includeSharedAssets","includeJavaModeResources")
511+
dependsOn("includeSharedAssets", "includeJavaModeResources")
474512
val dir = composeResources("modes/java/application/launch4j/bin/")
475513
val os = DefaultNativePlatform.getCurrentOperatingSystem()
476514
val platform = when {
@@ -601,7 +639,14 @@ afterEvaluate {
601639
tasks.named("prepareAppResources").configure {
602640
dependsOn("includeProcessingResources")
603641
// Make sure all libraries are bundled in the maven repository distributed with the app
604-
dependsOn(listOf("core","java:preprocessor", "java:gradle", "java:gradle:hotreload").map { project(":$it").tasks.named("publishAllPublicationsToAppRepository") })
642+
dependsOn(
643+
listOf(
644+
"core",
645+
"java:preprocessor",
646+
"java:gradle",
647+
"java:gradle:hotreload",
648+
"app:utils"
649+
).map { project(":$it").tasks.named("publishAllPublicationsToAppRepository") })
605650
}
606651
tasks.named("createDistributable").configure {
607652
dependsOn("includeJdk")

app/src/processing/app/gradle/GradleJob.kt

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,11 @@ import org.gradle.tooling.events.problems.internal.DefaultSingleProblemEvent
1717
import org.gradle.tooling.events.task.TaskFinishEvent
1818
import org.gradle.tooling.events.task.TaskStartEvent
1919
import org.gradle.tooling.events.task.TaskSuccessResult
20-
import processing.app.Base.DEBUG
21-
import processing.app.Base.getSketchbookFolder
22-
import processing.app.Base.getVersionName
20+
import processing.app.Base.*
2321
import processing.app.Language.text
2422
import processing.app.Messages
2523
import processing.app.Platform
2624
import processing.app.Platform.getContentFile
27-
import processing.app.Platform.getSettingsFolder
2825
import processing.app.Settings
2926
import processing.app.Sketch
3027
import processing.app.gradle.Log.Companion.startLogServer
@@ -33,7 +30,6 @@ import processing.app.ui.EditorStatus
3330
import java.nio.file.Path
3431
import kotlin.io.path.deleteIfExists
3532
import kotlin.io.path.writeText
36-
import kotlin.text.split
3733

3834
/*
3935
* The gradle job runs the gradle tasks and manages the gradle connection

app/src/processing/app/gradle/GradleSettings.kt

Lines changed: 5 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,43 +1,21 @@
11
package processing.app.gradle
22

3-
import androidx.compose.foundation.VerticalScrollbar
4-
import androidx.compose.foundation.background
5-
import androidx.compose.foundation.gestures.scrollable
6-
import androidx.compose.foundation.layout.Arrangement
7-
import androidx.compose.foundation.layout.Box
8-
import androidx.compose.foundation.layout.Column
9-
import androidx.compose.foundation.layout.Row
10-
import androidx.compose.foundation.layout.fillMaxHeight
11-
import androidx.compose.foundation.layout.fillMaxSize
12-
import androidx.compose.foundation.layout.padding
13-
import androidx.compose.foundation.layout.size
14-
import androidx.compose.foundation.rememberScrollState
15-
import androidx.compose.foundation.rememberScrollbarAdapter
16-
import androidx.compose.foundation.verticalScroll
3+
import androidx.compose.foundation.*
4+
import androidx.compose.foundation.layout.*
175
import androidx.compose.material.Checkbox
18-
import androidx.compose.material.MaterialTheme
19-
import androidx.compose.material.Surface
206
import androidx.compose.material.Text
217
import androidx.compose.runtime.Composable
228
import androidx.compose.runtime.LaunchedEffect
23-
import androidx.compose.runtime.getValue
24-
import androidx.compose.runtime.mutableStateOf
259
import androidx.compose.runtime.remember
26-
import androidx.compose.runtime.setValue
2710
import androidx.compose.runtime.snapshotFlow
2811
import androidx.compose.ui.Alignment
2912
import androidx.compose.ui.Modifier
3013
import androidx.compose.ui.awt.ComposePanel
31-
import androidx.compose.ui.awt.SwingPanel
3214
import androidx.compose.ui.graphics.Color
3315
import androidx.compose.ui.text.font.FontWeight
3416
import androidx.compose.ui.text.style.TextAlign
35-
import androidx.compose.ui.text.style.TextDecoration
3617
import androidx.compose.ui.unit.dp
37-
import androidx.compose.ui.unit.em
3818
import androidx.compose.ui.unit.sp
39-
import com.formdev.flatlaf.util.SwingUtils
40-
import com.github.ajalt.mordant.rendering.TextStyle
4119
import kotlinx.coroutines.CoroutineScope
4220
import kotlinx.coroutines.Dispatchers
4321
import kotlinx.coroutines.launch
@@ -47,12 +25,9 @@ import processing.app.Sketch
4725
import processing.app.ui.Editor
4826
import processing.app.ui.EditorFooter
4927
import processing.app.ui.Theme
50-
import processing.app.ui.theme.ProcessingTheme
28+
import processing.app.ui.theme.PDETheme
5129
import processing.app.watchFile
52-
import java.awt.Dimension
53-
import java.util.UUID
54-
import javax.swing.JCheckBox
55-
import javax.swing.JPanel
30+
import java.util.*
5631
import javax.swing.SwingUtilities
5732

5833
class GradleSettings{
@@ -107,7 +82,7 @@ class GradleSettings{
10782
}
10883
val stateVertical = rememberScrollState(0)
10984

110-
ProcessingTheme {
85+
PDETheme {
11186
Box {
11287
Row(
11388
modifier = Modifier

app/src/processing/app/ui/Editor.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import processing.app.*;
2828
import processing.app.Formatter;
2929
import processing.app.contrib.ContributionManager;
30+
import processing.app.gradle.GradleService;
3031
import processing.app.laf.PdeMenuItemUI;
3132
import processing.app.syntax.*;
3233
import processing.core.PApplet;
@@ -213,10 +214,10 @@ public void windowDeactivated(WindowEvent e) {
213214
spacer.setAlignmentX(Component.LEFT_ALIGNMENT);
214215
box.add(spacer);
215216
}
216-
if (Platform.isLinux()) {
217-
setUndecorated(true);
218-
getRootPane().setWindowDecorationStyle(JRootPane.FRAME);
219-
}
217+
if (Platform.isLinux()) {
218+
setUndecorated(true);
219+
getRootPane().setWindowDecorationStyle(JRootPane.FRAME);
220+
}
220221

221222
rebuildModePopup();
222223
toolbar = createToolbar();
@@ -373,7 +374,7 @@ public void actionPerformed(ActionEvent e) {
373374
});
374375
}
375376

376-
PreferencesEvents.onUpdated(this::updateTheme);
377+
PreferencesEvents.onUpdated(this::updateTheme);
377378
}
378379

379380

@@ -1075,7 +1076,7 @@ public void buildDevelopMenu(){
10751076
var updateTrigger = new JMenuItem(Language.text("menu.develop.check_for_updates"));
10761077
updateTrigger.addActionListener(e -> {
10771078
Preferences.unset("update.last");
1078-
Preferences.setInteger("update.beta_welcome", 0);
1079+
Preferences.setInteger("update.beta_welcome", 0);
10791080
new UpdateCheck(base);
10801081
});
10811082
developMenu.add(updateTrigger);

build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ plugins {
66

77
alias(libs.plugins.versions)
88
alias(libs.plugins.mavenPublish) apply false
9-
10-
alias(libs.plugins.versions)
119
}
1210

1311
// Set the build directory to not /build to prevent accidental deletion through the clean action

java/build.gradle.kts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
import org.gradle.nativeplatform.platform.internal.DefaultNativePlatform
2-
31
plugins {
42
java
53
}
@@ -68,7 +66,7 @@ tasks.register<Copy>("copyCore"){
6866
into(coreProject.layout.projectDirectory.dir("library"))
6967
}
7068

71-
val legacyLibraries = arrayOf("io","net")
69+
val legacyLibraries = arrayOf("io", "net")
7270
legacyLibraries.forEach { library ->
7371
tasks.register<Copy>("library-$library-extraResources"){
7472
val build = project(":java:libraries:$library").tasks.named("build")
@@ -101,8 +99,11 @@ libraries.forEach { library ->
10199
from(project.layout.buildDirectory.dir("library"))
102100
into(javaMode("/libraries/$library"))
103101
}
104-
tasks.named("extraResources"){ dependsOn("library-$library-extraResources") }
102+
bundle.configure {
103+
dependsOn(name)
104+
}
105105
}
106+
106107
tasks.jar { dependsOn("extraResources") }
107108
tasks.processResources{ finalizedBy("extraResources") }
108109
tasks.compileTestJava{ finalizedBy("extraResources") }

java/preprocessor/build.gradle.kts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ publishing{
4949
mavenPublishing{
5050
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
5151

52-
// Only sign if signing is set up
53-
if(project.hasProperty("signing.keyId") || project.hasProperty("signingInMemoryKey"))
5452
signAllPublications()
5553

5654
pom{

settings.gradle.kts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ include(
1212
"java",
1313
"java:preprocessor",
1414
"java:gradle",
15+
"java:gradle:hotreload",
1516
"java:libraries:dxf",
1617
"java:libraries:io",
1718
"java:libraries:net",

0 commit comments

Comments
 (0)