Skip to content

Commit bc60f49

Browse files
committed
linting
Signed-off-by: Jay DeLuca <jaydeluca4@gmail.com>
1 parent aa12656 commit bc60f49

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

.github/workflows/nightly-benchmarks.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,16 @@ jobs:
5454
run: |
5555
# 3 forks, 3 warmup, 5 measurement iterations (~60 min total)
5656
DEFAULT_ARGS="-f 3 -wi 3 -i 5"
57-
JMH_ARGS="${{ github.event.inputs.jmh_args }}"
58-
JMH_ARGS="${JMH_ARGS:-$DEFAULT_ARGS}"
57+
JMH_ARGS="${INPUT_JMH_ARGS:-$DEFAULT_ARGS}"
5958
6059
echo "Running benchmarks with args: $JMH_ARGS"
6160
6261
java -jar ./benchmarks/target/benchmarks.jar \
6362
-rf json \
6463
-rff benchmark-results.json \
6564
$JMH_ARGS
65+
env:
66+
INPUT_JMH_ARGS: ${{ github.event.inputs.jmh_args }}
6667

6768
- name: Generate benchmark summary
6869
run: |

.mise/tasks/generate_benchmark_summary.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,8 @@ def generate_markdown(results: List, commit_sha: str, repo: str) -> str:
180180
else:
181181
md.append(f"- **Commit:** `{commit_short}` (local run)")
182182
md.append(f"- **JDK:** {jdk_version} ({vm_name})")
183-
md.append(f"- **Benchmark config:** {forks} fork(s), {warmup_iters} warmup, {measure_iters} measurement, {threads} threads")
183+
bench_cfg = f"{forks} fork(s), {warmup_iters} warmup, {measure_iters} measurement, {threads} threads"
184+
md.append(f"- **Benchmark config:** {bench_cfg}")
184185

185186
hw_parts = []
186187
if sysinfo.get("cpu_model"):
@@ -297,9 +298,17 @@ def generate_markdown(results: List, commit_sha: str, repo: str) -> str:
297298
md.append("")
298299
md.append("| Benchmark | Description |")
299300
md.append("|:----------|:------------|")
300-
md.append("| **CounterBenchmark** | Compares counter increment performance across Prometheus, OpenTelemetry, simpleclient (0.16.0), and Codahale Metrics |")
301-
md.append("| **HistogramBenchmark** | Compares histogram observation performance (classic buckets vs native/exponential) |")
302-
md.append("| **TextFormatUtilBenchmark** | Measures metric exposition format writing speed (Prometheus text vs OpenMetrics) |")
301+
md.append(
302+
"| **CounterBenchmark** | Counter increment performance: "
303+
"Prometheus, OpenTelemetry, simpleclient, Codahale |"
304+
)
305+
md.append(
306+
"| **HistogramBenchmark** | Histogram observation performance "
307+
"(classic vs native/exponential) |"
308+
)
309+
md.append(
310+
"| **TextFormatUtilBenchmark** | Metric exposition format writing speed |"
311+
)
303312
md.append("")
304313
return "\n".join(md)
305314

0 commit comments

Comments
 (0)