rpm: Skip explicit publishing after package upload if repo has autopublish enabled

balasankarc · balasankarc · commit a481737b0403 · 2025-12-12T01:08:10.000+05:30
closes #1284 Signed-off-by: Balasankar 'Balu' C <balu@dravidam.net>
diff --git a/CHANGES/1284.bugfix b/CHANGES/1284.bugfix
@@ -0,0 +1 @@
+Fix CLI explicitly creating a publication after package upload when repo has autopublish enabled
diff --git a/pulpcore/cli/rpm/content.py b/pulpcore/cli/rpm/content.py
@@ -401,7 +401,12 @@ def upload(
 
         # Sanity: ignore publish|use_temp unless destination-repository has been specified
         use_tmp = final_dest_repo_ctx and kwargs["use_temp_repository"]
-        do_publish = final_dest_repo_ctx and kwargs["publish"]
+        # Publish if autopublish is not enabled on the repository
+        do_publish = (
+            final_dest_repo_ctx
+            and kwargs["publish"]
+            and not final_dest_repo_ctx.entity["autopublish"]
+        )
 
         # Sanity: ignore relative_path if directory specified
         if directory and kwargs["relative_path"]:

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix CLI explicitly creating a publication after package upload when repo has autopublish enabled`