diff --git a/.ci/scripts/validate_commit_message.py b/.ci/scripts/validate_commit_message.py index 04e3fd30..bb9a7d8b 100755 --- a/.ci/scripts/validate_commit_message.py +++ b/.ci/scripts/validate_commit_message.py @@ -24,7 +24,8 @@ r"^DO\s*NOT\s*MERGE", r"^EXPERIMENT", r"^FIXUP", - r"Apply suggestions from code review", + r"^fixup!", # This is created by 'git commit --fixup' + r"Apply suggestions from code review", # This usually comes from GitHub ] try: CHANGELOG_EXTS = [ @@ -40,7 +41,11 @@ if NOISSUE_MARKER in message: sys.exit(f"Do not add '{NOISSUE_MARKER}' in the commit message.") -if any((re.match(pattern, message, re.IGNORECASE) for pattern in BLOCKING_REGEX)): +blocking_matches = [m for m in (re.match(pattern, message) for pattern in BLOCKING_REGEX) if m] +if blocking_matches: + print("Found these phrases in the commit message:") + for m in blocking_matches: + print(" - " + m.group(0)) sys.exit("This PR is not ready for consumption.") g = Github(os.environ.get("GITHUB_TOKEN")) diff --git a/.github/template_gitref b/.github/template_gitref index bdfe03f3..201b085a 100644 --- a/.github/template_gitref +++ b/.github/template_gitref @@ -1 +1 @@ -2021.08.26-420-gf332a34 +2021.08.26-426-g3a3f8a1 diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index 692ba626..d5a55a50 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -13,7 +13,7 @@ on: jobs: test: if: "endsWith(github.base_ref, 'main')" - runs-on: "ubuntu-20.04" + runs-on: "ubuntu-latest" defaults: run: working-directory: "pulp_python" @@ -48,7 +48,7 @@ jobs: no-test: if: "!endsWith(github.base_ref, 'main')" - runs-on: "ubuntu-20.04" + runs-on: "ubuntu-latest" steps: - run: | echo "Skip docs testing on non-main branches."