Fix solve_{lower,upper}_triangular deprecation

Replaced with solve_triangular

Author: Armavica

pymc/distributions/dist_math.py

@@ -34,13 +34,14 @@
 from aesara.scalar import UnaryScalarOp, upgrade_to_float_no_complex
 from aesara.tensor import gammaln
 from aesara.tensor.elemwise import Elemwise
-from aesara.tensor.slinalg import Cholesky
-from aesara.tensor.slinalg import solve_lower_triangular as solve_lower
-from aesara.tensor.slinalg import solve_upper_triangular as solve_upper
+from aesara.tensor.slinalg import Cholesky, SolveTriangular
 
 from pymc.aesaraf import floatX
 from pymc.distributions.shape_utils import to_tuple
 
+solve_lower = SolveTriangular(lower=True)
+solve_upper = SolveTriangular(lower=False)
+
 f = floatX
 c = -0.5 * np.log(2.0 * np.pi)
 _beta_clip_values = {

pymc/distributions/multivariate.py

@@ -33,9 +33,7 @@
 from aesara.tensor.random.basic import dirichlet, multinomial, multivariate_normal
 from aesara.tensor.random.op import RandomVariable, default_supp_shape_from_params
 from aesara.tensor.random.utils import broadcast_params, normalize_size_param
-from aesara.tensor.slinalg import Cholesky
-from aesara.tensor.slinalg import solve_lower_triangular as solve_lower
-from aesara.tensor.slinalg import solve_upper_triangular as solve_upper
+from aesara.tensor.slinalg import Cholesky, SolveTriangular
 from aesara.tensor.type import TensorType
 from scipy import linalg, stats
 
@@ -79,6 +77,9 @@
     "StickBreakingWeights",
 ]
 
+solve_lower = SolveTriangular(lower=True)
+solve_upper = SolveTriangular(lower=False)
+
 
 class SimplexContinuous(Continuous):
     """Base class for simplex continuous distributions"""

pymc/gp/util.py

@@ -19,15 +19,10 @@
 
 from aesara.compile import SharedVariable
 from aesara.tensor.slinalg import (  # noqa: W0611; pylint: disable=unused-import
+    SolveTriangular,
     cholesky,
     solve,
 )
-from aesara.tensor.slinalg import (  # noqa: W0611; pylint: disable=unused-import
-    solve_lower_triangular as solve_lower,
-)
-from aesara.tensor.slinalg import (  # noqa: W0611; pylint: disable=unused-import
-    solve_upper_triangular as solve_upper,
-)
 from aesara.tensor.var import TensorConstant
 from scipy.cluster.vq import kmeans
 
@@ -41,6 +36,9 @@
 
 JITTER_DEFAULT = 1e-6
 
+solve_lower = SolveTriangular(lower=True)
+solve_upper = SolveTriangular(lower=False)
+
 
 def replace_with_values(vars_needed, replacements=None, model=None):
     R"""

pymc/math.py

@@ -230,8 +230,8 @@ def kron_vector_op(v):
 
 # Define kronecker functions that work on 1D and 2D arrays
 kron_dot = partial(kron_matrix_op, op=at.dot)
-kron_solve_lower = partial(kron_matrix_op, op=at.slinalg.solve_lower_triangular)
-kron_solve_upper = partial(kron_matrix_op, op=at.slinalg.solve_upper_triangular)
+kron_solve_lower = partial(kron_matrix_op, op=at.slinalg.SolveTriangular(lower=True))
+kron_solve_upper = partial(kron_matrix_op, op=at.slinalg.SolveTriangular(lower=False))
 
 
 def flat_outer(a, b):

pymc/tests/test_math.py

@@ -116,7 +116,7 @@ def test_kron_solve_lower():
     x = np.random.rand(tot_size).reshape((tot_size, 1))
     # Construct entire kronecker product then solve
     big = kronecker(*Ls)
-    slow_ans = at.slinalg.solve_lower_triangular(big, x)
+    slow_ans = at.slinalg.solve_triangular(big, x, lower=True)
     # Use tricks to avoid construction of entire kronecker product
     fast_ans = kron_solve_lower(Ls, x)
     np.testing.assert_array_almost_equal(slow_ans.eval(), fast_ans.eval())