Skip to content

Commit abe06e0

Browse files
committed
Update code for linting issues
1 parent 88183ff commit abe06e0

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

src/pip/_internal/index/collector.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -231,9 +231,8 @@ def parse_links(page: IndexContent) -> Iterable[Link]:
231231
if content_type_l.startswith("application/vnd.pypi.simple.v1+json"):
232232
data = json.loads(page.content)
233233
project_track_urls = set(data.get("meta", {}).get("tracks", []))
234-
# repo_alt_urls = set(data.get("alternate-locations", []))
235-
# repo_alt_urls.add(page.url)
236234
repo_alt_urls = set(data.get("alternate-locations", []))
235+
repo_alt_urls.add(page.url)
237236
for file in data.get("files", []):
238237
link = Link.from_json(
239238
file,
@@ -252,9 +251,8 @@ def parse_links(page: IndexContent) -> Iterable[Link]:
252251

253252
base_url = parser.base_url or url
254253
for anchor in parser.anchors:
255-
# repo_alt_urls = parser.repo_alt_urls or set()
256-
# repo_alt_urls.add(page.url)
257254
repo_alt_urls = parser.repo_alt_urls or set()
255+
repo_alt_urls.add(page.url)
258256
link = Link.from_element(
259257
anchor,
260258
page_url=url,

src/pip/_internal/index/package_finder.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1385,7 +1385,7 @@ def check_multiple_remote_repositories(
13851385
if not any(ns & other for j, other in enumerate(namespaces) if i != j):
13861386
raise UnsafeMultipleRemoteRepositories(
13871387
package=project_name,
1388-
remote_repositories=ns,
1388+
remote_repositories={u for u in ns if u is not None},
13891389
)
13901390

13911391
all_declared_sources = set().union(*namespaces)
@@ -1394,7 +1394,7 @@ def check_multiple_remote_repositories(
13941394
if invalid_sources:
13951395
raise UnsafeMultipleRemoteRepositories(
13961396
package=project_name,
1397-
remote_repositories=invalid_sources,
1397+
remote_repositories={u for u in invalid_sources if u is not None},
13981398
)
13991399

14001400
return None

tests/unit/test_index.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
from __future__ import annotations
22

33
import logging
4-
from typing import Set
54

65
import pytest
6+
from _pytest.logging import LogCaptureFixture
77

88
from pip._vendor.packaging.specifiers import SpecifierSet
99
from pip._vendor.packaging.tags import Tag
@@ -919,8 +919,8 @@ def _make_mock_candidate_check_remote_repo(
919919
candidate_name: str | None = None,
920920
version: str | None = None,
921921
comes_from_url: str | None = None,
922-
project_track_urls: Set[str] | None = None,
923-
repo_alt_urls: Set[str] | None = None,
922+
project_track_urls: set[str] | None = None,
923+
repo_alt_urls: set[str] | None = None,
924924
) -> InstallationCandidate:
925925
if candidate_name is None:
926926
candidate_name = "mypackage"
@@ -1088,7 +1088,10 @@ def _make_mock_candidate_check_remote_repo(
10881088
],
10891089
)
10901090
def test_check_multiple_remote_repositories(
1091-
caplog, candidates: list[InstallationCandidate], project_name: str, expected
1091+
caplog: LogCaptureFixture,
1092+
candidates: list[InstallationCandidate],
1093+
project_name: str,
1094+
expected: Type[Exception] | None,
10921095
) -> None:
10931096
caplog.set_level(logging.DEBUG)
10941097
if expected:

0 commit comments

Comments
 (0)