Merge pull request #2950 from Wurschdhaud/fix-2949

wrap editfamily in try except to catch non revit errors

Author: jmcouffin

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Inspect.pulldown/ListFamilySizeCreator.pushbutton/ListFamilySizeCreator_script.py

@@ -7,6 +7,7 @@
 from pyrevit import revit, forms, script, DB, HOST_APP
 
 output = script.get_output()
+logger = script.get_logger()
 
 FIELDS = ["Size", "Name", "Category", "Creator", "Count"]
 # temporary path for saving families
@@ -150,14 +151,19 @@ def print_sorted(families, group_by):
     for fam in all_fams:
         with revit.ErrorSwallower() as swallower:
             if fam.IsEditable:
-                fam_doc = revit.doc.EditFamily(fam)
+                try:
+                    fam_doc = revit.doc.EditFamily(fam)
+                except Exception as ex:
+                    logger.warning(
+                        "Skipping family '%s': could not open for edit: %s",
+                        fam.Name, ex
+                    )
+                    continue
                 fam_path = fam_doc.PathName
                 # if the family path does not exists, save it temporary
                 #  only if the wasn't opened when the script was started
                 if fam_doc.Title not in opened_families and (
                         not fam_path or not os.path.exists(fam_path)):
-                    # edit family
-                    fam_doc = revit.doc.EditFamily(fam)
                     # save with temporary path, to know family size
                     fam_path = os.path.join(temp_dir, fam_doc.Title)
                     fam_doc.SaveAs(fam_path, save_as_options)