Merge pull request #2936 from Wurschdhaud/chore-cleanup-sb

chore: cleanup sb navigator

Author: jmcouffin

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Section Box Navigator.pushbutton/SectionBoxNavigator.xaml

@@ -1,6 +1,6 @@
 <Window xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
         xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-        Title="Section Box Navigator" Height="670" Width="600" 
+        Title="Section Box Navigator" Height="635" Width="560" 
         ShowInTaskbar="False" Topmost="True"
         ScrollViewer.VerticalScrollBarVisibility="Disabled">
     <Window.Resources>
@@ -368,7 +368,7 @@
             <StackPanel Orientation="Horizontal" Margin="5">
                 <CheckBox x:Name="chkPreview" Content="Show preview on hover" 
                         Margin="5" IsChecked="True"/>
-                <CheckBox x:Name="chkAutoupdate" Content="Autoupdate UI on Events" 
+                <CheckBox x:Name="chkAutoupdate" Content="Update UI on Events" 
                         Margin="5" IsChecked="True"/>
                 <CheckBox x:Name="chkIncludeLinks" Content="Include Linked Levels and Grids" 
                         Margin="5" IsChecked="False"

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Section Box Navigator.pushbutton/script.py

@@ -7,7 +7,6 @@
 from pyrevit.revit import events
 from pyrevit.compat import get_elementid_value_func
 from pyrevit import DB, UI
-from pyrevit import traceback
 
 from sectionbox_navigation import (
     get_all_levels,
@@ -49,7 +48,6 @@
 length_unit_symbol_label = None
 if not length_unit_symbol.Empty():
     length_unit_symbol_label = DB.LabelUtils.GetLabelForSymbol(length_unit_symbol)
-ufu = DB.UnitFormatUtils
 
 DEFAULT_NUDGE_VALUE_MM = 500.0
 default_nudge_value = DB.UnitUtils.Convert(
@@ -72,7 +70,7 @@ def create_preview_mesh(section_box, color):
         )
         return mesh
     except Exception:
-        logger.error("Error creating preview mesh: {}".format(traceback.format_exc()))
+        logger.exception("Error creating preview mesh.")
         return None
 
 
@@ -126,6 +124,10 @@ def create_adjusted_box(
     return new_box
 
 
+def format_length_value(value):
+    return DB.UnitFormatUtils.Format(doc.GetUnits(), DB.SpecTypeId.Length, value, False)
+
+
 # --------------------
 # Event Handler
 # --------------------
@@ -266,13 +268,9 @@ def update_info(self):
             )
 
             if top_level_elevation:
-                top_level_elevation = ufu.Format(
-                    doc.GetUnits(), DB.SpecTypeId.Length, top_level_elevation, False
-                )
+                top_level_elevation = format_length_value(top_level_elevation)
             if bottom_level_elevation:
-                bottom_level_elevation = ufu.Format(
-                    doc.GetUnits(), DB.SpecTypeId.Length, bottom_level_elevation, False
-                )
+                bottom_level_elevation = format_length_value(bottom_level_elevation)
 
             # Update top info
             if top_level:
@@ -282,9 +280,7 @@ def update_info(self):
             else:
                 self.txtTopLevel.Text = "Top: No level above"
 
-            top = ufu.Format(
-                doc.GetUnits(), DB.SpecTypeId.Length, transformed_max.Z, False
-            )
+            top = format_length_value(transformed_max.Z)
             self.txtTopPosition.Text = "Position: {}".format(top)
 
             # Update bottom info
@@ -295,13 +291,11 @@ def update_info(self):
             else:
                 self.txtBottomLevel.Text = "Bottom: No level below"
 
-            bottom = ufu.Format(
-                doc.GetUnits(), DB.SpecTypeId.Length, transformed_min.Z, False
-            )
+            bottom = format_length_value(transformed_min.Z)
             self.txtBottomPosition.Text = "Position: {}".format(bottom)
 
         except Exception:
-            logger.error("Error updating info: {}".format(traceback.format_exc()))
+            logger.exception("Error updating info.")
 
     def show_status_message(self, column, message, message_type="info"):
         """
@@ -608,9 +602,8 @@ def do_level_move(self, params):
                         )
             else:
                 # Nudge mode - show nudge amount
-                nudge_display = ufu.Format(
-                    doc.GetUnits(), DB.SpecTypeId.Length, abs(nudge_amount), False
-                )
+                nudge_display = format_length_value(abs(nudge_amount))
+
                 self.show_status_message(
                     1,
                     "Nudged {} by {} {}".format(target, nudge_display, movement),
@@ -634,9 +627,7 @@ def do_expand_shrink(self, params):
             max_z_change=adjustment,
         ):
             # Success - show informative message
-            amount_display = ufu.Format(
-                doc.GetUnits(), DB.SpecTypeId.Length, amount, False
-            )
+            amount_display = format_length_value(amount)
             operation = "Expanded" if is_expand else "Shrunk"
             self.show_status_message(
                 3,
@@ -806,9 +797,8 @@ def do_grid_move(self, params):
                 )
             else:
                 # Nudge mode
-                nudge_display = ufu.Format(
-                    doc.GetUnits(), DB.SpecTypeId.Length, nudge_amount, False
-                )
+                nudge_display = format_length_value(nudge_amount)
+
                 direction_display = cardinal_dir.upper()
                 self.show_status_message(
                     2,
@@ -1365,20 +1355,6 @@ def btn_align_box_to_face_click(self, sender, e):
         self.event_handler.parameters = self.pending_action
         self.ext_event.Raise()
 
-    def btn_refresh_click(self, sender, e):
-        """Manually refresh the information."""
-        self.all_levels = get_all_levels(doc, self.chkIncludeLinks.IsChecked)
-        self.all_grids = get_all_grids(doc, self.chkIncludeLinks.IsChecked)
-        self.update_info()
-        # Only update status if there's no current message (i.e., status is "Ready" or empty)
-        if self.txtGridStatus.Text == "..." or self.txtGridStatus.Text == "-":
-            self.update_grid_status()
-        if (
-            self.txtExpandActionsStatus.Text == "..."
-            or self.txtExpandActionsStatus.Text == "-"
-        ):
-            self.update_expand_actions_status()
-
     def chkIncludeLinks_checked(self, sender, e):
         """Refresh levels and grids when checkbox is toggled."""
         self.all_levels = get_all_levels(doc, self.chkIncludeLinks.IsChecked)
@@ -1500,7 +1476,7 @@ def form_closed(self, sender, args):
                 logger.warning("Error refreshing view: {}".format(ex))
 
         except Exception:
-            logger.error("Error during cleanup: {}".format(traceback.format_exc()))
+            logger.exception("Error during cleanup.")
 
 
 # ---------

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Section Box Navigator.pushbutton/sectionbox_navigation.py

@@ -153,7 +153,7 @@ def find_next_grid_in_direction(start_point, direction_vector, grids, tolerance)
             else:
                 # Regular DB.Grid - access Curve directly
                 curve = grid.Curve
-                
+
             if not curve or not isinstance(curve, DB.Line):
                 continue
         except (AttributeError, Exception):