Refactor Section Box Navigator scripts for improved error handling and code clarity. Updated UI elements to handle empty unit labels gracefully, optimized bounding box retrieval, and streamlined grid sorting logic.

Fixed button hovering

Author: jmcouffin

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Section Box Navigator.pushbutton/SectionBoxNavigator.xaml

@@ -7,14 +7,23 @@
         <Style TargetType="Button">
             <Setter Property="BorderThickness" Value="0"/>
             <Setter Property="Height" Value="30"/>
+            <Setter Property="Background" Value="#E0E0E0"/>
             <Setter Property="Template">
                 <Setter.Value>
                     <ControlTemplate TargetType="Button">
-                        <Border Background="{TemplateBinding Background}" 
+                        <Border x:Name="border" Background="{TemplateBinding Background}" 
                                 CornerRadius="5"
                                 Padding="{TemplateBinding Padding}">
                             <ContentPresenter HorizontalAlignment="Center" VerticalAlignment="Center"/>
                         </Border>
+                        <ControlTemplate.Triggers>
+                            <Trigger Property="IsMouseOver" Value="True">
+                                <Setter TargetName="border" Property="Background" Value="#B0D0FF"/>
+                            </Trigger>
+                            <Trigger Property="IsPressed" Value="True">
+                                <Setter TargetName="border" Property="Background" Value="#90B0E0"/>
+                            </Trigger>
+                        </ControlTemplate.Triggers>
                     </ControlTemplate>
                 </Setter.Value>
             </Setter>

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Section Box Navigator.pushbutton/script.py

@@ -203,11 +203,11 @@ def __init__(self, xaml_file_name):
                 "Length Label (adjust in Project Units): \n" + length_unit_label
             )
         self.txtLevelNudgeAmount.Text = str(round(default_nudge_value, 3))
-        self.txtLevelNudgeUnit.Text = length_unit_symbol_label
+        self.txtLevelNudgeUnit.Text = length_unit_symbol_label or ""
         self.txtExpandAmount.Text = str(round(default_nudge_value, 3))
-        self.txtExpandUnit.Text = length_unit_symbol_label
+        self.txtExpandUnit.Text = length_unit_symbol_label or ""
         self.txtGridNudgeAmount.Text = str(round(default_nudge_value, 3))
-        self.txtGridNudgeUnit.Text = length_unit_symbol_label
+        self.txtGridNudgeUnit.Text = length_unit_symbol_label or ""
 
         self.update_info()
         self.update_grid_status()
@@ -791,7 +791,7 @@ def do_align_to_view(self, params):
             if not elements:
                 self.show_status_message(1, "No cropbox or elements found to extend scopebox to", "error")
                 return
-            boxes = [el.get_BoundingBox(source_view) for el in elements]
+            boxes = [b for b in [el.get_BoundingBox(source_view) for el in elements] if b]
             min_x = min(b.Min.X for b in boxes if b)
             min_y = min(b.Min.Y for b in boxes if b)
             max_x = max(b.Max.X for b in boxes if b)

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Section Box Navigator.pushbutton/sectionbox_actions.py

@@ -74,8 +74,6 @@ def align_to_face(doc, uidoc):
     if not isinstance(current_view, DB.View3D):
         return
     try:
-        world_normal = None
-
         with forms.WarningBar(title="Pick a face on a solid object"):
             reference = uidoc.Selection.PickObject(
                 UI.Selection.ObjectType.PointOnElement,

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Section Box Navigator.pushbutton/sectionbox_geometry.py

@@ -14,10 +14,10 @@ def get_section_box_info(view, datafilename):
             view_boxes = script.load_data(datafilename)
         except Exception:
             return None
-        view_id_value = get_elementid_value(view.Id)  
-        if view_id_value not in view_boxes:  
-            return None 
-        bbox_data = view_boxes[view_id_value]
+        view_id_value = get_elementid_value(view.Id)
+        bbox_data = view_boxes.get(view_id_value)
+        if not bbox_data:
+            return None
         section_box = revit.deserialize(bbox_data)
     else:
         section_box = view.GetSectionBox()

extensions/pyRevitTools.extension/pyRevit.tab/Modify.panel/3D.pulldown/Section Box Navigator.pushbutton/sectionbox_navigation.py

@@ -25,7 +25,7 @@ def get_all_levels(doc, include_linked=False):
                     levels.append(lvl_host_elev)
 
     # Sort by elevation (transformed if linked)
-    levels = sorted(levels, key=lambda x: getattr(x, 'Elevation', x.Elevation))
+    levels = sorted(levels, key=lambda x: x.Elevation)
     return levels
 
 
@@ -144,13 +144,15 @@ def find_next_grid_in_direction(start_point, direction_vector, grids, tolerance)
 
     for grid in grids:
         try:
-            # Handle both regular Grid and LinkedGrid objects / Exception on multi segment grids
+            # Handle LinkedGrid objects (has Curve attribute)
             if hasattr(grid, 'Curve'):
                 curve = grid.Curve
+            # Handle regular DB.Grid objects (has Element.Curve)
             elif hasattr(grid, 'Element'):
                 curve = grid.Element.Curve
             else:
-                curve = grid.Curve  # Regular DB.Grid
+                # Regular DB.Grid - access Curve directly
+                curve = grid.Curve
 
             if not curve or not isinstance(curve, DB.Line):
                 continue