Skip to content

Commit ebc33cc

Browse files
committed
use lib commands
1 parent 74865be commit ebc33cc

File tree

3 files changed

+8
-18
lines changed
  • extensions/pyRevitTools.extension/pyRevit.tab
    • Analysis.panel/Tools.stack/Inspect.pulldown/Count Faces.pushbutton
    • Selection.panel/select.stack/Select.pulldown/Select All Objects Passing Filter.pushbutton
    • Toggles.panel/toggles2.stack/SectionBox.pushbutton

3 files changed

+8
-18
lines changed

extensions/pyRevitTools.extension/pyRevit.tab/Analysis.panel/Tools.stack/Inspect.pulldown/Count Faces.pushbutton/script.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,7 @@
55
output = script.get_output()
66
output.close_others()
77

8-
elements = (
9-
DB.FilteredElementCollector(doc)
10-
.OfClass(DB.FamilyInstance)
11-
.WhereElementIsNotElementType()
12-
.ToElements()
13-
)
8+
elements = revit.query.get_elements_by_class(DB.FamilyInstance, doc=doc)
149

1510
# Storage
1611
processed_types = {} # typeId: {name, coarse, medium, fine}

extensions/pyRevitTools.extension/pyRevit.tab/Selection.panel/select.stack/Select.pulldown/Select All Objects Passing Filter.pushbutton/script.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
only_current_view = my_config.get_option("only_current_view", True)
1212
reverse_filter = my_config.get_option("reverse_filter", False)
1313

14-
filters = list(DB.FilteredElementCollector(doc).OfClass(DB.ParameterFilterElement))
14+
filters = list(revit.query.get_elements_by_class(DB.ParameterFilterElement, doc=doc))
1515

1616
if not filters:
1717
forms.alert("No Filters found", exitscript=True)
@@ -56,4 +56,5 @@
5656
if exclude_nested and isinstance(el, DB.FamilyInstance) and el.SuperComponent:
5757
continue
5858
element_ids.append(el.Id)
59-
uidoc.Selection.SetElementIds(List[DB.ElementId](element_ids))
59+
60+
revit.get_selection().set_to(element_ids)

extensions/pyRevitTools.extension/pyRevit.tab/Toggles.panel/toggles2.stack/SectionBox.pushbutton/script.py

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
"""Toggles visibility of section box in current 3D view"""
22

3-
import pickle
4-
53
from pyrevit import framework
64
from pyrevit import revit, DB, script
75
from pyrevit.compat import get_elementid_value_func
@@ -11,7 +9,7 @@
119
active_view_id_value = get_elementid_value(active_view.Id)
1210

1311
logger = script.get_logger()
14-
datafile = script.get_document_data_file("SectionBox", "pym")
12+
DATA_SLOTNAME = "SectionBox"
1513

1614
my_config = script.get_config()
1715
scope = my_config.get_option("scope", "Visibility")
@@ -50,21 +48,17 @@ def toggle_sectionbox_active():
5048
logger.error("Not a 3D view. Operation canceled.")
5149
return
5250

53-
sectionbox_active_state = active_view.IsSectionBoxActive
54-
5551
try:
56-
with open(datafile, "rb") as f:
57-
view_boxes = pickle.load(f)
52+
view_boxes = script.load_data(DATA_SLOTNAME)
5853
except Exception:
5954
view_boxes = {}
6055

61-
if sectionbox_active_state:
56+
if active_view.IsSectionBoxActive:
6257
try:
6358
sectionbox = active_view.GetSectionBox()
6459
if sectionbox:
6560
view_boxes[active_view_id_value] = revit.serialize(sectionbox)
66-
with open(datafile, "wb") as f:
67-
pickle.dump(view_boxes, f)
61+
script.store_data(DATA_SLOTNAME, view_boxes)
6862
active_view.IsSectionBoxActive = False
6963
except Exception as e:
7064
logger.error("Error saving section box: {}".format(e))

0 commit comments

Comments
 (0)