Split up the async yield fixture tests for more specificity

Author: altendky

testing/test_basic.py

@@ -450,40 +450,98 @@ def test_succeed(this, that):
 
 
 @skip_if_no_async_generators()
-def test_async_yield_fixture(testdir, cmd_opts):
+def test_async_yield_fixture_can_await(testdir, cmd_opts):
     test_file = """
     from twisted.internet import reactor, defer
     import pytest
     import pytest_twisted
 
-    @pytest_twisted.async_yield_fixture(
-        scope="function",
-        params=["fs", "imap", "web", "archie"],
-    )
-    async def foo(request):
+    @pytest_twisted.async_yield_fixture()
+    async def foo():
         d1, d2 = defer.Deferred(), defer.Deferred()
         reactor.callLater(0.01, d1.callback, 1)
-        reactor.callLater(0.02, d2.callback, request.param)
+        reactor.callLater(0.02, d2.callback, 2)
         await d1
 
         # Twisted doesn't allow calling back with a Deferred as a value.
         # This deferred is being wrapped up in a tuple to sneak through.
         # https://github.com/twisted/twisted/blob/c0f1394c7bfb04d97c725a353a1f678fa6a1c602/src/twisted/internet/defer.py#L459
         yield d2,
 
-        if request.param == "archie":
-            yield 42
-
     @pytest_twisted.inlineCallbacks
     def test_succeed(foo):
         x = yield foo[0]
-        if x == "web":
-            raise RuntimeError("baz")
+        assert x == 2
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    assert_outcomes(rr, {"passed": 1})
+
+
+@skip_if_no_async_generators()
+def test_async_yield_fixture_failed_test(testdir, cmd_opts):
+    test_file = """
+    from twisted.internet import reactor, defer
+    import pytest
+    import pytest_twisted
+
+    @pytest_twisted.async_yield_fixture()
+    async def foo(request):
+        yield 92
+
+    @pytest_twisted.inlineCallbacks
+    def test_succeed(foo):
+        assert False
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    rr.stdout.fnmatch_lines(lines2=["E*assert False"])
+    assert_outcomes(rr, {"failed": 1})
+
+
+@skip_if_no_async_generators()
+def test_async_yield_fixture_test_exception(testdir, cmd_opts):
+    test_file = """
+    from twisted.internet import reactor, defer
+    import pytest
+    import pytest_twisted
+    
+    class UniqueLocalException(Exception):
+        pass
+
+    @pytest_twisted.async_yield_fixture()
+    async def foo(request):
+        yield 92
+
+    @pytest_twisted.inlineCallbacks
+    def test_succeed(foo):
+        raise UniqueLocalException("some message")
+    """
+    testdir.makepyfile(test_file)
+    rr = testdir.run(*cmd_opts, timeout=timeout)
+    rr.stdout.fnmatch_lines(lines2=["E*.UniqueLocalException: some message*"])
+    assert_outcomes(rr, {"failed": 1})
+
+
+@skip_if_no_async_generators()
+def test_async_yield_fixture_yields_twice(testdir, cmd_opts):
+    test_file = """
+    from twisted.internet import reactor, defer
+    import pytest
+    import pytest_twisted
+
+    @pytest_twisted.async_yield_fixture()
+    async def foo():
+        yield 92
+        yield 36
+
+    @pytest_twisted.inlineCallbacks
+    def test_succeed(foo):
+        assert foo == 92
     """
     testdir.makepyfile(test_file)
     rr = testdir.run(*cmd_opts, timeout=timeout)
-    # TODO: this is getting super imprecise...
-    assert_outcomes(rr, {"passed": 3, "failed": 1, "errors": 1})
+    assert_outcomes(rr, {"errors": 1, "failed": 1})
 
 
 @skip_if_no_async_generators()