Automatically add Host: to HTTP/1.1 requests

Author: Lukasa

hyper/http11/connection.py

@@ -101,11 +101,13 @@ def request(self, method, url, body=None, headers={}):
         if self._sock is None:
             self.connect()
 
-        # We may need extra headers. For now, we only add headers based on
-        # body content.
+        # We may need extra headers.
         if body:
             body_type = self._add_body_headers(headers, body)
 
+        if b'host' not in headers:
+            headers[b'host'] = self.host
+
         # Begin by emitting the header block.
         self._send_headers(method, url, headers)
 

test/test_http11.py

@@ -48,6 +48,7 @@ def test_basic_request(self):
         expected = (
             b"GET /get HTTP/1.1\r\n"
             b"User-Agent: hyper\r\n"
+            b"host: http2bin.org\r\n"
             b"\r\n"
         )
         received = b''.join(sock.queue)
@@ -69,6 +70,7 @@ def test_request_with_bytestring_body(self):
             b"POST /post HTTP/1.1\r\n"
             b"User-Agent: hyper\r\n"
             b"content-length: 2\r\n"
+            b"host: http2bin.org\r\n"
             b"\r\n"
             b"hi"
         )
@@ -97,6 +99,7 @@ def fake_fstat(*args):
             expected = (
                 b"POST /post HTTP/1.1\r\n"
                 b"content-length: 16\r\n"
+                b"host: http2bin.org\r\n"
                 b"\r\n"
                 b"some binary data"
             )
@@ -121,6 +124,7 @@ def body():
         expected = (
             b"POST /post HTTP/1.1\r\n"
             b"transfer-encoding: chunked\r\n"
+            b"host: http2bin.org\r\n"
             b"\r\n"
             b"2\r\nhi\r\n"
             b"5\r\nthere\r\n"
@@ -146,6 +150,7 @@ def body():
         expected = (
             b"POST /post HTTP/1.1\r\n"
             b"content-length: 10\r\n"
+            b"host: http2bin.org\r\n"
             b"\r\n"
             b"hitheresir"
         )
@@ -169,6 +174,7 @@ def test_chunked_overrides_body(self):
         expected = (
             b"POST /post HTTP/1.1\r\n"
             b"transfer-encoding: chunked\r\n"
+            b"host: http2bin.org\r\n"
             b"\r\n"
             b"8\r\noneline\n\r\n"
             b"b\r\nanotherline\r\n"