Skip to content

Commit 219d1c6

Browse files
committed
Flask wrapper status code fix
1 parent dcb5324 commit 219d1c6

File tree

4 files changed

+14
-13
lines changed

4 files changed

+14
-13
lines changed

openapi_core/validators.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,8 @@ def validate(self, request, response):
159159
return ResponseValidationResult(errors, data, headers)
160160

161161
try:
162-
operation_response = operation.get_response(str(response.status))
162+
operation_response = operation.get_response(
163+
str(response.status_code))
163164
# don't process if invalid response status code
164165
except InvalidResponse as exc:
165166
errors.append(exc)

openapi_core/wrappers.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,17 +109,17 @@ def mimetype(self):
109109
class BaseOpenAPIResponse(object):
110110

111111
body = NotImplemented
112-
status = NotImplemented
112+
status_code = NotImplemented
113113

114114
mimetype = NotImplemented
115115

116116

117117
class MockResponse(BaseOpenAPIRequest):
118118

119-
def __init__(self, data, status=200, mimetype='application/json'):
119+
def __init__(self, data, status_code=200, mimetype='application/json'):
120120
self.data = data
121121

122-
self.status = status
122+
self.status_code = status_code
123123
self.mimetype = mimetype
124124

125125

@@ -133,8 +133,8 @@ def data(self):
133133
return self.response.data
134134

135135
@property
136-
def status(self):
137-
return self.response.status
136+
def status_code(self):
137+
return self.response._status_code
138138

139139
@property
140140
def mimetype(self):

tests/integration/test_validators.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ def validator(self, spec):
175175

176176
def test_invalid_server(self, validator):
177177
request = MockRequest('http://petstore.invalid.net/v1', 'get', '/')
178-
response = MockResponse('Not Found', status=404)
178+
response = MockResponse('Not Found', status_code=404)
179179

180180
result = validator.validate(request, response)
181181

@@ -186,7 +186,7 @@ def test_invalid_server(self, validator):
186186

187187
def test_invalid_operation(self, validator):
188188
request = MockRequest(self.host_url, 'get', '/v1')
189-
response = MockResponse('Not Found', status=404)
189+
response = MockResponse('Not Found', status_code=404)
190190

191191
result = validator.validate(request, response)
192192

@@ -197,7 +197,7 @@ def test_invalid_operation(self, validator):
197197

198198
def test_invalid_response(self, validator):
199199
request = MockRequest(self.host_url, 'get', '/v1/pets')
200-
response = MockResponse('Not Found', status=409)
200+
response = MockResponse('Not Found', status_code=409)
201201

202202
result = validator.validate(request, response)
203203

tests/integration/test_wrappers.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,16 +96,16 @@ class TestFlaskOpenAPIResponse(object):
9696

9797
@pytest.fixture
9898
def response_factory(self):
99-
def create_response(body, status=200):
100-
return Response('Not Found', status=404)
99+
def create_response(data, status_code=200):
100+
return Response(data, status=status_code)
101101
return create_response
102102

103103
def test_invalid_server(self, response_factory):
104-
response = response_factory('Not Found', status=404)
104+
response = response_factory('Not Found', status_code=404)
105105

106106
openapi_response = FlaskOpenAPIResponse(response)
107107

108108
assert openapi_response.response == response
109109
assert openapi_response.data == response.data
110-
assert openapi_response.status == response.status
110+
assert openapi_response.status_code == response._status_code
111111
assert openapi_response.mimetype == response.mimetype

0 commit comments

Comments
 (0)