Fix malformed schema traversal to report validation errors instead of internal exceptions

Author: p1c2u

openapi_spec_validator/validation/keywords.py

@@ -19,6 +19,7 @@
     DuplicateOperationIDError,
 )
 from openapi_spec_validator.validation.exceptions import ExtraParametersError
+from openapi_spec_validator.validation.exceptions import OpenAPIValidationError
 from openapi_spec_validator.validation.exceptions import (
     ParameterDuplicateError,
 )
@@ -98,7 +99,14 @@ def __call__(
         self, schema: SchemaPath, require_properties: bool = True
     ) -> Iterator[ValidationError]:
         schema_value = schema.read_value()
-        if not hasattr(schema_value, "__getitem__"):
+
+        try:
+            self.default_validator.value_validator_cls.check_schema(schema_value)
+        except Exception as err:
+            yield OpenAPIValidationError.create_from(err)
+            return
+
+        if isinstance(schema_value, bool):
             return
 
         assert self.schema_ids_registry is not None

tests/integration/test_main.py

@@ -193,6 +193,34 @@ def test_schema_stdin(capsys):
     assert "stdin: OK\n" in out
 
 
+def test_malformed_schema_stdin(capsys):
+    """Malformed schema from STDIN reports validation error."""
+    spec_io = StringIO(
+        """
+openapi: 3.1.0
+info:
+  version: "1"
+  title: "Title"
+components:
+  schemas:
+    Component:
+      type: object
+      properties:
+        name: string
+"""
+    )
+
+    testargs = ["--schema", "3.1.0", "-"]
+    with mock.patch("openapi_spec_validator.__main__.sys.stdin", spec_io):
+        with pytest.raises(SystemExit):
+            main(testargs)
+
+    out, err = capsys.readouterr()
+    assert not err
+    assert "stdin: Validation Error:" in out
+    assert "stdin: OK" not in out
+
+
 def test_version(capsys):
     """Test --version flag outputs correct version."""
     testargs = ["--version"]

tests/integration/validation/test_exceptions.py

@@ -1,5 +1,6 @@
 from openapi_spec_validator import OpenAPIV2SpecValidator
 from openapi_spec_validator import OpenAPIV30SpecValidator
+from openapi_spec_validator import OpenAPIV31SpecValidator
 from openapi_spec_validator.validation.exceptions import (
     DuplicateOperationIDError,
 )
@@ -495,3 +496,29 @@ def validate(to_validate) -> bool:
         assert len(errors_list) == 1
         assert errors_list[0].__class__ == OpenAPIValidationError
         assert errors_list[0].message == ("'invalid' is not a 'custom'")
+
+    def test_malformed_property_schema(self):
+        spec = {
+            "openapi": "3.1.0",
+            "info": {
+                "title": "Test Api",
+                "version": "0.0.1",
+            },
+            "components": {
+                "schemas": {
+                    "Component": {
+                        "type": "object",
+                        "properties": {
+                            "name": "string",
+                        },
+                    }
+                },
+            },
+        }
+
+        errors = OpenAPIV31SpecValidator(spec).iter_errors()
+
+        errors_list = list(errors)
+        assert len(errors_list) == 1
+        assert errors_list[0].__class__ == OpenAPIValidationError
+        assert "'string' is not of type 'object'" in errors_list[0].message