Skip to content

Commit 7268a13

Browse files
authored
Remove _env instance attributes (#1817)
* Remove _env instance attributes * remove ENV from folium.folium * remove unused imports * fix pre-commit complaint
1 parent 9ab63f7 commit 7268a13

File tree

3 files changed

+7
-11
lines changed

3 files changed

+7
-11
lines changed

folium/folium.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from typing import Any, List, Optional, Sequence, Union
99

1010
from branca.element import Element, Figure, MacroElement
11-
from jinja2 import Environment, PackageLoader, Template
11+
from jinja2 import Template
1212

1313
from folium.elements import JSCSSMixin
1414
from folium.map import FitBounds, Layer
@@ -22,9 +22,6 @@
2222
validate_location,
2323
)
2424

25-
ENV = Environment(loader=PackageLoader("folium", "templates"))
26-
27-
2825
_default_js = [
2926
("leaflet", "https://cdn.jsdelivr.net/npm/leaflet@1.9.3/dist/leaflet.js"),
3027
("jquery", "https://code.jquery.com/jquery-1.12.4.min.js"),
@@ -262,7 +259,6 @@ def __init__(
262259
):
263260
super().__init__()
264261
self._name = "Map"
265-
self._env = ENV
266262

267263
self._png_image: Optional[bytes] = None
268264
self.png_enabled = png_enabled

folium/raster_layers.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,6 @@ def __init__(
122122
name=self.tile_name, overlay=overlay, control=control, show=show
123123
)
124124
self._name = "TileLayer"
125-
self._env = ENV
126125

127126
tiles_flat = "".join(tiles.lower().strip().split())
128127
if tiles_flat in {"cloudmade", "mapbox", "mapboxbright", "mapboxcontrolroom"}:
@@ -133,14 +132,14 @@ def __init__(
133132
"argument. See the documentation of the `TileLayer` class."
134133
)
135134
templates = list(
136-
self._env.list_templates(filter_func=lambda x: x.startswith("tiles/"))
135+
ENV.list_templates(filter_func=lambda x: x.startswith("tiles/"))
137136
)
138137
tile_template = "tiles/" + tiles_flat + "/tiles.txt"
139138
attr_template = "tiles/" + tiles_flat + "/attr.txt"
140139

141140
if tile_template in templates and attr_template in templates:
142-
self.tiles = self._env.get_template(tile_template).render()
143-
attr = self._env.get_template(attr_template).render()
141+
self.tiles = ENV.get_template(tile_template).render()
142+
attr = ENV.get_template(attr_template).render()
144143
else:
145144
self.tiles = tiles
146145
if not attr:

tests/test_folium.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import folium
2020
from folium import TileLayer
2121
from folium.features import Choropleth, GeoJson
22+
from folium.raster_layers import ENV
2223

2324
rootpath = os.path.abspath(os.path.dirname(__file__))
2425

@@ -120,8 +121,8 @@ def test_builtin_tile(self):
120121
tiles = "".join(tiles.lower().strip().split())
121122
url = "tiles/{}/tiles.txt".format
122123
attr = "tiles/{}/attr.txt".format
123-
url = m._env.get_template(url(tiles)).render()
124-
attr = m._env.get_template(attr(tiles)).render()
124+
url = ENV.get_template(url(tiles)).render()
125+
attr = ENV.get_template(attr(tiles)).render()
125126

126127
assert m._children[tiles].tiles == url
127128
assert htmlsafe_json_dumps(attr) in m._parent.render()

0 commit comments

Comments
 (0)