Skip to content

Commit 0056118

Browse files
authored
buildbot: pass --fail-env-changed to regrtest (#2509)
Make tests fail if a test altered the environment.
1 parent 7eebeb8 commit 0056118

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

Makefile.pre.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1035,7 +1035,7 @@ buildbottest: build_all platform
10351035
-@if which pybuildbot.identify >/dev/null 2>&1; then \
10361036
pybuildbot.identify "CC='$(CC)'" "CXX='$(CXX)'"; \
10371037
fi
1038-
$(TESTRUNNER) -j 1 -u all -W --slowest --timeout=$(TESTTIMEOUT) $(TESTOPTS)
1038+
$(TESTRUNNER) -j 1 -u all -W --slowest --fail-env-changed --timeout=$(TESTTIMEOUT) $(TESTOPTS)
10391039

10401040
QUICKTESTOPTS= $(TESTOPTS) -x test_subprocess test_io test_lib2to3 \
10411041
test_multibytecodec test_urllib2_localnet test_itertools \

Tools/buildbot/test.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@ if "%1"=="+q" (set rt_opts=%rt_opts:-q=%) & shift & goto CheckOpts
1616
if NOT "%1"=="" (set regrtest_args=%regrtest_args% %1) & shift & goto CheckOpts
1717

1818
echo on
19-
call "%here%..\..\PCbuild\rt.bat" %rt_opts% -uall -rwW --slowest --timeout=1200 %regrtest_args%
19+
call "%here%..\..\PCbuild\rt.bat" %rt_opts% -uall -rwW --slowest --timeout=1200 --fail-env-changed %regrtest_args%

0 commit comments

Comments
 (0)