Skip to content

Commit 0305cfe

Browse files
committed
fix ResourceWarning when writing a unwritable gzipfile
1 parent c5e77ba commit 0305cfe

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

Lib/gzip.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -245,8 +245,13 @@ def __init__(self, filename=None, mode=None,
245245

246246
self.fileobj = fileobj
247247

248-
if self.mode == WRITE:
249-
self._write_gzip_header(compresslevel)
248+
try:
249+
if self.mode == WRITE:
250+
self._write_gzip_header(compresslevel)
251+
except BaseException:
252+
# Avoid a ResourceWarning if the write fails, eg read-only file or KI
253+
self.fileobj = None
254+
raise
250255

251256
@property
252257
def mtime(self):

0 commit comments

Comments
 (0)