address code review from Steve

Author: pablogsal

Doc/using/cmdline.rst

@@ -604,7 +604,11 @@ Miscellaneous options
      .. versionadded:: 3.13
 
    * ``-X disable_remote_debug`` disables the remote debugging support as described
-     in :pep:`768`. This option is only available on some platforms and will do nothing
+     in :pep:`768`.  This includes both the functionality to schedule code for
+     execution in another process and the functionality to receive code for
+     execution in the current process.
+
+     This option is only available on some platforms and will do nothing
      if is not supported on the current system. See also
      :envvar:`PYTHON_DISABLE_REMOTE_DEBUG` and :pep:`768`.
 
@@ -1170,7 +1174,9 @@ conflict.
 .. envvar:: PYTHON_DISABLE_REMOTE_DEBUG
 
    If this variable is set to a non-empty string, it disables the remote
-   debugging feature described in :pep:`768`.
+   debugging feature described in :pep:`768`. This includes both the functionality
+   to schedule code for execution in another process and the functionality to
+   receive code for execution in the current process.
 
    See also the :option:`-X disable_remote_debug` command-line option.
 

Doc/using/configure.rst

@@ -665,7 +665,9 @@ also be used to improve performance.
    Deactivate remote debugging support described in :pep:`768` (enabled by default).
    When this flag is provided the code that allows the interpreter to schedule the
    execution of a Python file in a separate process as described in :pep:`768` is
-   not compiled.
+   not compiled. This includes both the functionality to schedule code to be executed
+   and the functionality to receive code to be executed.
+
 
    .. versionadded:: next
 

Doc/whatsnew/3.14.rst

@@ -97,7 +97,7 @@ PEP 768: Safe external debugger interface for CPython
 
 :pep:`768` introduces a zero-overhead debugging interface that allows debuggers and profilers
 to safely attach to running Python processes. This is a significant enhancement to Python's
-debugging capabilities, bringing them in line with other major programming languages.
+debugging capabilities allowing debuggers to forego unsafe alternatives.
 
 The new interface provides safe execution points for attaching debugger code without modifying
 the interpreter's normal execution path or adding runtime overhead. This enables tools to
@@ -124,23 +124,7 @@ Here's a simple example that inspects object types in a running Python process:
      # Create a temporary script
      with tempfile.NamedTemporaryFile(mode='w', suffix='.py', delete=False) as f:
          script_path = f.name
-         f.write("""
-     import gc
-     import collections
-
-     # Collect all objects managed by the garbage collector
-     gc.collect()
-
-     # Count objects by type
-     type_counts = collections.Counter(type(obj).__name__
-                                       for obj in gc.get_objects())
-
-     # Print the most common types
-     print("Most common object types in process:")
-     for type_name, count in type_counts.most_common(10):
-         print(f"  {type_name}: {count}")
-     """)
-
+         f.write("import my_debugger; my_debugger.connect(HOST_PROCESS)")
      try:
          # Execute in process with PID 1234
          print("Behold! An offering:")

Lib/test/test_sys.py

@@ -1965,6 +1965,7 @@ def _supports_remote_attaching():
                     "Test only runs on Linux, Windows and MacOS")
 @unittest.skipIf(sys.platform == "linux" and not _supports_remote_attaching(),
                     "Test only runs on Linux with process_vm_readv support")
+@test.support.cpython_only
 class TestRemoteExec(unittest.TestCase):
     def tearDown(self):
         test.support.reap_children()
@@ -2152,5 +2153,31 @@ def test_remote_exec_invalid_script_path(self):
         with self.assertRaises(OSError):
             sys.remote_exec(os.getpid(), "invalid_script_path")
 
+    def test_remote_exec_in_process_without_debug_fails_envvar(self):
+        """Test remote exec in a process without remote debugging enabled"""
+        script = os_helper.TESTFN + '_remote.py'
+        self.addCleanup(os_helper.unlink, script)
+        with open(script, 'w') as f:
+            f.write('print("Remote script executed successfully!")')
+        env = os.environ.copy()
+        env['PYTHON_DISABLE_REMOTE_DEBUG'] = '1'
+
+        _, out, err = assert_python_failure('-c', f'import os, sys; sys.remote_exec(os.getpid(), "{script}")', **env)
+        self.assertIn(b"Remote debugging is not enabled", err)
+        self.assertEqual(out, b"")
+
+    def test_remote_exec_in_process_without_debug_fails_xoption(self):
+        """Test remote exec in a process without remote debugging enabled"""
+        script = os_helper.TESTFN + '_remote.py'
+        self.addCleanup(os_helper.unlink, script)
+        with open(script, 'w') as f:
+            f.write('print("Remote script executed successfully!")')
+
+        _, out, err = assert_python_failure('-Xdisable-remote-debug', '-c', f'import os, sys; sys.remote_exec(os.getpid(), "{script}")')
+        self.assertIn(b"Remote debugging is not enabled", err)
+        self.assertEqual(out, b"")
+
+
+
 if __name__ == "__main__":
     unittest.main()

Python/remote_debugging.c

@@ -104,7 +104,7 @@ cleanup_proc_handle(proc_handle_t *handle) {
     handle->pid = 0;
 }
 
-#ifdef Py_SUPPORTS_REMOTE_DEBUG
+#if defined(Py_REMOTE_DEBUG) && defined(Py_SUPPORTS_REMOTE_DEBUG)
 
 #if defined(__APPLE__) && TARGET_OS_OSX
 static uintptr_t
@@ -918,15 +918,26 @@ send_exec_to_proc_handle(proc_handle_t *handle, int tid, const char *debugger_sc
     return 0;
 }
 
-#endif // defined(Py_SUPPORTS_REMOTE_DEBUG)
+#endif // defined(Py_REMOTE_DEBUG) && defined(Py_SUPPORTS_REMOTE_DEBUG)
 
 int
 _PySysRemoteDebug_SendExec(int pid, int tid, const char *debugger_script_path)
 {
-#ifndef Py_SUPPORTS_REMOTE_DEBUG
+#if !defined(Py_SUPPORTS_REMOTE_DEBUG)
     PyErr_SetString(PyExc_RuntimeError, "Remote debugging is not supported on this platform");
     return -1;
+#elif !defined(Py_REMOTE_DEBUG)
+    PyErr_SetString(PyExc_RuntimeError, "Remote debugging support has not been compiled in");
+    return -1;
 #else
+
+    PyThreadState *tstate = _PyThreadState_GET();
+    const PyConfig *config = _PyInterpreterState_GetConfig(tstate->interp);
+    if (config->remote_debug != 1) {
+        PyErr_SetString(PyExc_RuntimeError, "Remote debugging is not enabled");
+        return -1;
+    }
+
     proc_handle_t handle;
     if (init_proc_handle(&handle, pid) < 0) {
         return -1;