Skip to content

Commit 1d9a5c0

Browse files
author
Daniil Dumchenko
committed
gh-133403: Type Tools/build/verify_ensurepip_wheels.py and check it with mypy
1 parent b97328e commit 1d9a5c0

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

Tools/build/mypy.ini

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
[mypy]
22
files =
33
Tools/build/compute-changes.py,
4-
Tools/build/generate_sbom.py
4+
Tools/build/generate_sbom.py,
5+
Tools/build/verify_ensurepip_wheels.py
56
pretty = True
67

78
# Make sure Python can still be built

Tools/build/verify_ensurepip_wheels.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@
2020
GITHUB_ACTIONS = os.getenv("GITHUB_ACTIONS") == "true"
2121

2222

23-
def print_notice(file_path: str, message: str) -> None:
23+
def print_notice(file_path: Path, message: str) -> None:
2424
if GITHUB_ACTIONS:
2525
message = f"::notice file={file_path}::{message}"
2626
print(message, end="\n\n")
2727

2828

29-
def print_error(file_path: str, message: str) -> None:
29+
def print_error(file_path: Path, message: str) -> None:
3030
if GITHUB_ACTIONS:
3131
message = f"::error file={file_path}::{message}"
3232
print(message, end="\n\n")
@@ -40,7 +40,7 @@ def verify_wheel(package_name: str) -> bool:
4040
for p in package_paths:
4141
print_error(p, f"Found more than one wheel for package {package_name}.")
4242
else:
43-
print_error("", f"Could not find a {package_name} wheel on disk.")
43+
print_error(Path(), f"Could not find a {package_name} wheel on disk.")
4444
return False
4545

4646
package_path = package_paths[0]
@@ -67,6 +67,7 @@ def verify_wheel(package_name: str) -> bool:
6767
return False
6868

6969
release_files = json.loads(raw_text)["releases"][package_version]
70+
expected_digest = ""
7071
for release_info in release_files:
7172
if package_path.name != release_info["filename"]:
7273
continue
@@ -95,6 +96,7 @@ def verify_wheel(package_name: str) -> bool:
9596
return True
9697

9798

99+
98100
if __name__ == "__main__":
99101
exit_status = int(not verify_wheel("pip"))
100102
raise SystemExit(exit_status)

0 commit comments

Comments
 (0)