Skip to content

Commit 32e27f6

Browse files
committed
pr feedback answered
- use the actual page URL - tighten the wording
1 parent 3a768df commit 32e27f6

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,20 @@ Improve a documentation page
2020
});
2121
</script>
2222

23-
We are always interested to hear about ways to improve the documentation.
23+
We are always interested to hear ideas about improvements to the documentation.
2424

2525
You were reading "PAGETITLE" at `<PAGEURL>`_. The source for that page is on
2626
`GitHub <https://github.com/python/cpython/blob/main/Doc/PAGESOURCE?plain=1>`_.
2727

28-
You have a few options for asking questions or suggesting changes:
28+
You have a few ways to ask questions or suggest changes:
2929

3030
- You can start a discussion about the page on the Python discussion forum.
3131
This link will start a pre-populated topic:
32-
`Question about "PAGETITLE" <https://discuss.python.org/new-topic?category=documentation&title=Question+about+%22PAGETITLE%22&body=About+the+page+at+PAGEURL%3A>`_.
32+
`Question about page "PAGETITLE" <https://discuss.python.org/new-topic?category=documentation&title=Question+about+page+%22PAGETITLE%22&body=About+the+page+at+PAGEURL%3A>`_.
3333

3434
- You can open an issue on the Python GitHub issue tracker. This link will
35-
create a new issue pre-populated with some information for you:
36-
`Docs: problem with "PAGETITLE" <https://github.com/python/cpython/issues/new?title=Docs%3A+problem+with+%22PAGETITLE%22&labels=docs&body=The+page+at+PAGEURL+has+a+problem%3A>`_.
35+
create a new pre-populated issue:
36+
`Docs: problem with page "PAGETITLE" <https://github.com/python/cpython/issues/new?title=Docs%3A+problem+with+page+%22PAGETITLE%22&labels=docs&body=The+page+at+PAGEURL+has+a+problem%3A>`_.
3737

3838
- You can `edit the page on GitHub <https://github.com/python/cpython/blob/main/Doc/PAGESOURCE?plain=1>`_
3939
to open a pull request and begin the contribution process.

Doc/tools/templates/customsourcelink.html

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33
document.addEventListener('DOMContentLoaded', () => {
44
const title = document.querySelector('meta[property="og:title"]').content;
55
const elements = document.querySelectorAll('.improvepage');
6+
const pageurl = window.location.href.split('?')[0];
67
elements.forEach(element => {
78
const url = new URL(element.href);
89
url.searchParams.set('pagetitle', title);
10+
url.searchParams.set('pageurl', pageurl);
911
element.href = url.toString();
1012
});
1113
});
@@ -14,7 +16,7 @@
1416
<h3>{{ _('This page') }}</h3>
1517
<ul class="this-page-menu">
1618
<li><a href="{{ pathto('bugs') }}">{% trans %}Report a bug{% endtrans %}</a></li>
17-
<li><a class="improvepage" href="{{ pathto('improvepage') }}?pageurl=https://docs.python.org/3/{{ pagename }}.html&pagesource={{ sourcename|replace('.rst.txt', '.rst') }}">{% trans %}Improve this page{% endtrans %}</a></li>
19+
<li><a class="improvepage" href="{{ pathto('improve-page') }}?pagesource={{ pagename }}.rst">{% trans %}Improve this page{% endtrans %}</a></li>
1820
<li>
1921
<a href="https://github.com/python/cpython/blob/main/Doc/{{ pagename }}.rst?plain=1"
2022
rel="nofollow">{{ _('Show source') }}

0 commit comments

Comments
 (0)