gh-93172: Remove unnecessary "if"s in binascii_a2b_qp_impl() from Modules/binascii.c (GH-93181)

oda-gitso · web-flow · commit 32e3b790bc58 · 2022-05-25T11:38:47.000-04:00
diff --git a/Modules/binascii.c b/Modules/binascii.c
@@ -1024,10 +1024,7 @@ binascii_a2b_qp_impl(PyObject *module, Py_buffer *data, int header)
             out++;
         }
     }
-    if ((rv = PyBytes_FromStringAndSize((char *)odata, out)) == NULL) {
-        PyMem_Free(odata);
-        return NULL;
-    }
+    rv = PyBytes_FromStringAndSize((char *)odata, out);
     PyMem_Free(odata);
     return rv;
 }
@@ -1232,10 +1229,7 @@ binascii_b2a_qp_impl(PyObject *module, Py_buffer *data, int quotetabs,
             }
         }
     }
-    if ((rv = PyBytes_FromStringAndSize((char *)odata, out)) == NULL) {
-        PyMem_Free(odata);
-        return NULL;
-    }
+    rv = PyBytes_FromStringAndSize((char *)odata, out);
     PyMem_Free(odata);
     return rv;
 }

Original file line number	Diff line number	Diff line change
`@@ -1024,10 +1024,7 @@ binascii_a2b_qp_impl(PyObject module, Py_buffer data, int header)`
`1024`	`1024`	`out++;`
`1025`	`1025`	`}`
`1026`	`1026`	`}`
`1027`		`- if ((rv = PyBytes_FromStringAndSize((char *)odata, out)) == NULL) {`
`1028`		`- PyMem_Free(odata);`
`1029`		`- return NULL;`
`1030`		`- }`
	`1027`	`+ rv = PyBytes_FromStringAndSize((char *)odata, out);`
`1031`	`1028`	`PyMem_Free(odata);`
`1032`	`1029`	`return rv;`
`1033`	`1030`	`}`
`@@ -1232,10 +1229,7 @@ binascii_b2a_qp_impl(PyObject module, Py_buffer data, int quotetabs,`
`1232`	`1229`	`}`
`1233`	`1230`	`}`
`1234`	`1231`	`}`
`1235`		`- if ((rv = PyBytes_FromStringAndSize((char *)odata, out)) == NULL) {`
`1236`		`- PyMem_Free(odata);`
`1237`		`- return NULL;`
`1238`		`- }`
	`1232`	`+ rv = PyBytes_FromStringAndSize((char *)odata, out);`
`1239`	`1233`	`PyMem_Free(odata);`
`1240`	`1234`	`return rv;`
`1241`	`1235`	`}`