gh-129694: Add test_exceptions to parallel TSAN jobs

This would catch the data race involving the MemoryError freelist that
was fixed in gh-129668.

Author: colesbury

Lib/test/libregrtest/tsan.py

@@ -33,6 +33,7 @@
 # the regression test runner with the `--parallel-threads` option enabled.
 TSAN_PARALLEL_TESTS = [
     'test_abc',
+    'test_exceptions',
 ]
 
 

Lib/test/support/__init__.py

@@ -2870,7 +2870,7 @@ def force_not_colorized(func):
     def wrapper(*args, **kwargs):
         with no_color():
             return func(*args, **kwargs)
-    return wrapper
+    return thread_unsafe(wrapper)  # modifying the environment is thread-unsafe
 
 
 def force_not_colorized_test_class(cls):

Lib/test/test_exceptions.py

@@ -60,6 +60,7 @@ def raise_catch(self, exc, excname):
             self.assertEqual(buf1, buf2)
             self.assertEqual(exc.__name__, excname)
 
+    @support.thread_unsafe("TESTFN")
     def testRaising(self):
         self.raise_catch(AttributeError, "AttributeError")
         self.assertRaises(AttributeError, getattr, sys, "undefined_attribute")
@@ -1361,6 +1362,7 @@ def test_unicode_error_str_does_not_crash(self):
                 self.assertIsInstance(str(exc), str)
 
     @no_tracing
+    @support.thread_unsafe("captures stderr")
     def test_badisinstance(self):
         # Bug #2542: if issubclass(e, MyException) raises an exception,
         # it should be ignored
@@ -1484,6 +1486,7 @@ def test_recursion_normalizing_infinite_exception(self):
         self.assertIn(b'Done.', out)
 
 
+    @support.thread_unsafe("uses sys.setrecursionlimit")
     def test_recursion_in_except_handler(self):
 
         def set_relative_recursion_limit(n):
@@ -1619,6 +1622,7 @@ class C(object):
 
     @cpython_only
     @unittest.skipIf(_testcapi is None, "requires _testcapi")
+    @support.thread_unsafe("gc_collect()")
     def test_memory_error_cleanup(self):
         # Issue #5437: preallocated MemoryError instances should not keep
         # traceback objects alive.
@@ -1668,6 +1672,7 @@ def test_errno_ENOTDIR(self):
             os.listdir(__file__)
         self.assertEqual(cm.exception.errno, errno.ENOTDIR, cm.exception)
 
+    @support.thread_unsafe("uses catch_unraisable_exception")
     def test_unraisable(self):
         # Issue #22836: PyErr_WriteUnraisable() should give sensible reports
         class BrokenDel:
@@ -1687,6 +1692,7 @@ def __del__(self):
                              f"deallocator {obj_repr}")
             self.assertIsNotNone(cm.unraisable.exc_traceback)
 
+    @support.thread_unsafe("captures stderr")
     def test_unhandled(self):
         # Check for sensible reporting of unhandled exceptions
         for exc_type in (ValueError, BrokenStrException):
@@ -1786,6 +1792,7 @@ def g():
                 next(i)
 
     @unittest.skipUnless(__debug__, "Won't work if __debug__ is False")
+    @support.thread_unsafe("modifies global AssertionError")
     def test_assert_shadowing(self):
         # Shadowing AssertionError would cause the assert statement to
         # misbehave.
@@ -1877,6 +1884,7 @@ def test_name_error_has_name(self):
         except NameError as exc:
             self.assertEqual("bluch", exc.name)
 
+    @support.thread_unsafe("captures stderr")
     def test_issue45826(self):
         # regression test for bpo-45826
         def f():
@@ -1893,6 +1901,7 @@ def f():
 
         self.assertIn("aab", err.getvalue())
 
+    @support.thread_unsafe("captures stderr")
     def test_issue45826_focused(self):
         def f():
             try:
@@ -2295,6 +2304,7 @@ class MySyntaxError(SyntaxError):
      ^^^^^
 """, err.getvalue())
 
+    @support.thread_unsafe("TESTFN")
     def test_encodings(self):
         self.addCleanup(unlink, TESTFN)
         source = (

Tools/tsan/suppressions_free_threading.txt

@@ -44,5 +44,12 @@ race_top:PyThreadState_Clear
 # Only seen on macOS, sample: https://gist.github.com/aisk/dda53f5d494a4556c35dde1fce03259c
 race_top:set_default_allocator_unlocked
 
+# gh-129701: data race during modification of refcount when interning strings
+race:intern_common
+
+# gh-128130: race on _PyRuntime.signals.unhandled_keyboard_interrupt
+race_top:_PyErr_Display
+race_top:run_eval_code_obj
+
 # https://gist.github.com/mpage/6962e8870606cfc960e159b407a0cb40
 thread:pthread_create