Skip to content

Commit 4e125ac

Browse files
committed
allow double quote in cookie values
1 parent 9c3ddf3 commit 4e125ac

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

Lib/http/cookies.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -433,7 +433,7 @@ def OutputString(self, attrs=None):
433433
#
434434

435435
_LegalKeyChars = r"\w\d!#%&'~_`><@,:/\$\*\+\-\.\^\|\)\(\?\}\{\="
436-
_LegalValueChars = _LegalKeyChars + r'\[\]'
436+
_LegalValueChars = _LegalKeyChars + r'"\[\]'
437437
_CookiePattern = re.compile(r"""
438438
\s* # Optional whitespace at start of cookie
439439
(?P<key> # Start of group 'key'

Lib/test/test_http_cookies.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,16 @@ def test_basic(self):
4747
'Set-Cookie: d=r',
4848
'Set-Cookie: f=h'
4949
))
50+
},
51+
52+
{'data': 'before="value; inside=val"ue; after=value"',
53+
'dict': {'before': '"value', 'inside': 'val"ue', 'after': 'value"'},
54+
'repr': "<SimpleCookie: after='value\"' before='\"value' inside='val\"ue'>",
55+
'output': '\n'.join((
56+
'Set-Cookie: after=value"',
57+
'Set-Cookie: before="value',
58+
'Set-Cookie: inside=val"ue',
59+
))
5060
}
5161
]
5262

0 commit comments

Comments
 (0)