testing: can it be places here???

albertedwardson · albertedwardson · commit 61c235cc61c0 · 2025-10-10T13:16:56.000Z
diff --git a/Python/bytecodes.c b/Python/bytecodes.c
@@ -5362,10 +5362,6 @@ dummy_func(
 
         tier2 op(_MAKE_WARM, (--)) {
             current_executor->vm_data.warm = true;
-            // It's okay if this ends up going negative.
-            if (--tstate->interp->trace_run_counter == 0) {
-                _Py_set_eval_breaker_bit(tstate, _PY_EVAL_JIT_INVALIDATE_COLD_BIT);
-            }
         }
 
         tier2 op(_FATAL_ERROR, (--)) {
diff --git a/Python/executor_cases.c.h b/Python/executor_cases.c.h
diff --git a/Tools/jit/trampoline.c b/Tools/jit/trampoline.c
@@ -12,5 +12,8 @@ _JIT_ENTRY(
 ) {
     typedef DECLARE_TARGET((*jit_func));
     jit_func jitted = (jit_func)exec->jit_code;
+    if (--tstate->interp->trace_run_counter == 0) {
+        _Py_set_eval_breaker_bit(tstate, _PY_EVAL_JIT_INVALIDATE_COLD_BIT);
+    }
     return jitted(frame, stack_pointer, tstate);
 }

Original file line number	Diff line number	Diff line change
`@@ -5362,10 +5362,6 @@ dummy_func(`
`5362`	`5362`
`5363`	`5363`	`tier2 op(_MAKE_WARM, (--)) {`
`5364`	`5364`	`current_executor->vm_data.warm = true;`
`5365`		`- // It's okay if this ends up going negative.`
`5366`		`- if (--tstate->interp->trace_run_counter == 0) {`
`5367`		`- _Py_set_eval_breaker_bit(tstate, _PY_EVAL_JIT_INVALIDATE_COLD_BIT);`
`5368`		`- }`
`5369`	`5365`	`}`
`5370`	`5366`
`5371`	`5367`	`tier2 op(_FATAL_ERROR, (--)) {`
Original file line number	Diff line number	Diff line change
`@@ -12,5 +12,8 @@ _JIT_ENTRY(`
`12`	`12`	`) {`
`13`	`13`	`typedef DECLARE_TARGET((*jit_func));`
`14`	`14`	`jit_func jitted = (jit_func)exec->jit_code;`
	`15`	`+ if (--tstate->interp->trace_run_counter == 0) {`
	`16`	`+ _Py_set_eval_breaker_bit(tstate, _PY_EVAL_JIT_INVALIDATE_COLD_BIT);`
	`17`	`+ }`
`15`	`18`	`return jitted(frame, stack_pointer, tstate);`
`16`	`19`	`}`