no need to exclude negative

Author: iritkatriel

Python/specialize.c

@@ -2417,31 +2417,30 @@ binary_op_fail_kind(int oparg, PyObject *lhs, PyObject *rhs)
 /* long-long */
 
 static inline int
-is_nonnegative_compactlong(PyObject *v)
+is_compactlong(PyObject *v)
 {
     return PyLong_CheckExact(v) &&
-           (!_PyLong_IsNegative((PyLongObject *)v)) &&
            _PyLong_IsCompact((PyLongObject *)v);
 }
 
 static int
-nonnegative_compactlongs_guard(PyObject *lhs, PyObject *rhs)
+compactlongs_guard(PyObject *lhs, PyObject *rhs)
 {
-    return (is_nonnegative_compactlong(lhs) && is_nonnegative_compactlong(rhs));
+    return (is_compactlong(lhs) && is_compactlong(rhs));
 }
 
-#define NONNEGATIVE_LONGS_ACTION(NAME, OP) \
+#define BITWISE_LONGS_ACTION(NAME, OP) \
     static PyObject * \
     (NAME)(PyObject *lhs, PyObject *rhs) \
     { \
         Py_ssize_t rhs_val = _PyLong_CompactValue((PyLongObject *)rhs); \
         Py_ssize_t lhs_val = _PyLong_CompactValue((PyLongObject *)lhs); \
         return PyLong_FromLong(lhs_val OP rhs_val); \
     }
-NONNEGATIVE_LONGS_ACTION(nonnegative_compactlongs_or, |)
-NONNEGATIVE_LONGS_ACTION(nonnegative_compactlongs_and, &)
-NONNEGATIVE_LONGS_ACTION(nonnegative_compactlongs_xor, ^)
-#undef NONNEGATIVE_LONGS_ACTION
+BITWISE_LONGS_ACTION(compactlongs_or, |)
+BITWISE_LONGS_ACTION(compactlongs_and, &)
+BITWISE_LONGS_ACTION(compactlongs_xor, ^)
+#undef BITWISE_LONGS_ACTION
 
 /* float-long */
 
@@ -2495,10 +2494,10 @@ LONG_FLOAT_ACTION(compactlong_float_multiply, *)
 LONG_FLOAT_ACTION(compactlong_float_true_div, /)
 #undef LONG_FLOAT_ACTION
 
-static _PyBinaryOpSpecializationDescr nonnegative_compactlongs_specs[NB_OPARG_LAST+1] = {
-    [NB_OR] = {nonnegative_compactlongs_guard, nonnegative_compactlongs_or},
-    [NB_AND] = {nonnegative_compactlongs_guard, nonnegative_compactlongs_and},
-    [NB_XOR] = {nonnegative_compactlongs_guard, nonnegative_compactlongs_xor},
+static _PyBinaryOpSpecializationDescr compactlongs_specs[NB_OPARG_LAST+1] = {
+    [NB_OR] = {compactlongs_guard, compactlongs_or},
+    [NB_AND] = {compactlongs_guard, compactlongs_and},
+    [NB_XOR] = {compactlongs_guard, compactlongs_xor},
 };
 
 static _PyBinaryOpSpecializationDescr float_compactlong_specs[NB_OPARG_LAST+1] = {
@@ -2529,7 +2528,7 @@ binary_op_extended_specialization(PyObject *lhs, PyObject *rhs, int oparg,
 
     LOOKUP_SPEC(compactlong_float_specs, oparg);
     LOOKUP_SPEC(float_compactlong_specs, oparg);
-    LOOKUP_SPEC(nonnegative_compactlongs_specs, oparg);
+    LOOKUP_SPEC(compactlongs_specs, oparg);
 #undef LOOKUP_SPEC
     return 0;
 }

Tools/c-analyzer/cpython/ignored.tsv

@@ -378,7 +378,7 @@ Python/pylifecycle.c	-	INTERPRETER_TRAMPOLINE_CODEDEF	-
 Python/pystate.c	-	initial	-
 Python/specialize.c	-	adaptive_opcodes	-
 Python/specialize.c	-	cache_requirements	-
-Python/specialize.c	-	nonnegative_compactlongs_specs	-
+Python/specialize.c	-	compactlongs_specs	-
 Python/specialize.c	-	float_compactlong_specs	-
 Python/specialize.c	-	compactlong_float_specs	-
 Python/stdlib_module_names.h	-	_Py_stdlib_module_names	-