gh-116738: Address the review comments

Author: yoney

Lib/test/test_free_threading/test_heapq.py

@@ -88,7 +88,7 @@ def test_racing_heapreplace(self):
 
         def heapreplace_func(heap, replace_items):
             for item in replace_items:
-                popped_item = heapq.heapreplace(heap, item)
+                heapq.heapreplace(heap, item)
 
         self.run_concurrently(
             worker_func=heapreplace_func,
@@ -165,7 +165,7 @@ def test_racing_heapreplace_max(self):
 
         def heapreplace_max_func(max_heap, replace_items):
             for item in replace_items:
-                popped_item = heapq.heapreplace_max(max_heap, item)
+                heapq.heapreplace_max(max_heap, item)
 
         self.run_concurrently(
             worker_func=heapreplace_max_func,

Modules/_heapqmodule.c

@@ -133,7 +133,7 @@ _heapq_heappush_impl(PyObject *module, PyObject *heap, PyObject *item)
 {
     // In a free-threaded build, the heap is locked at this point.
     // Therefore, calling _PyList_AppendTakeRef() is safe and no overhead.
-    if (_PyList_AppendTakeRef((PyListObject *)heap, Py_NewRef(item)))
+    if (_PyList_AppendTakeRef((PyListObject *)heap, Py_XNewRef(item)))
         return NULL;
 
     if (siftdown((PyListObject *)heap, 0, PyList_GET_SIZE(heap)-1))
@@ -504,7 +504,7 @@ _heapq_heappush_max_impl(PyObject *module, PyObject *heap, PyObject *item)
 {
     // In a free-threaded build, the heap is locked at this point.
     // Therefore, calling _PyList_AppendTakeRef() is safe and no overhead.
-    if (_PyList_AppendTakeRef((PyListObject *)heap, Py_NewRef(item))) {
+    if (_PyList_AppendTakeRef((PyListObject *)heap, Py_XNewRef(item))) {
         return NULL;
     }