Remove unnecessary error check for PyUnicode_Type.tp_hash

mpage · mpage · commit a20a4a4f82e5 · 2024-12-23T10:41:40.000-08:00
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
@@ -1139,10 +1139,7 @@ check_keys_and_hash(PyDictKeysObject *dk, PyObject *key)
     Py_hash_t hash = unicode_get_hash(key);
     if (hash == -1) {
         hash = PyUnicode_Type.tp_hash(key);
-        if (hash == -1) {
-            PyErr_Clear();
-            return -1;
-        }
+        assert(hash != -1);
     }
     return hash;
 }

Original file line number	Diff line number	Diff line change
`@@ -1139,10 +1139,7 @@ check_keys_and_hash(PyDictKeysObject dk, PyObject key)`
`1139`	`1139`	`Py_hash_t hash = unicode_get_hash(key);`
`1140`	`1140`	`if (hash == -1) {`
`1141`	`1141`	`hash = PyUnicode_Type.tp_hash(key);`
`1142`		`- if (hash == -1) {`
`1143`		`- PyErr_Clear();`
`1144`		`- return -1;`
`1145`		`- }`
	`1142`	`+ assert(hash != -1);`
`1146`	`1143`	`}`
`1147`	`1144`	`return hash;`
`1148`	`1145`	`}`