Change PyUnstable_Long_Export() argument to PyObject*

Author: vstinner

Doc/c-api/long.rst

@@ -630,7 +630,7 @@ Import/Export API
       Array of unsigned digits.
 
 
-.. c:function:: int PyUnstable_Long_Export(PyLongObject *obj, PyUnstable_LongExport *export)
+.. c:function:: int PyUnstable_Long_Export(PyObject *obj, PyUnstable_LongExport *export)
 
    Export a Python :class:`int` object as an array of digits.
 

Include/cpython/longintrepr.h

@@ -176,7 +176,7 @@ typedef struct PyUnstable_LongExport {
 } PyUnstable_LongExport;
 
 PyAPI_FUNC(int) PyUnstable_Long_Export(
-    PyLongObject *obj,
+    PyObject *obj,
     PyUnstable_LongExport *long_export);
 PyAPI_FUNC(void) PyUnstable_Long_ReleaseExport(
     PyUnstable_LongExport *long_export);

Lib/test/test_capi/test_long.py

@@ -768,6 +768,13 @@ def test_long_export(self):
         self.assertEqual(pylong_export(shift**2 * 3 + shift * 2 + 1),
                          (0, [1, 2, 3]))
 
+        with self.assertRaises(TypeError):
+            pylong_export(1.0)
+        with self.assertRaises(TypeError):
+            pylong_export(0+1j)
+        with self.assertRaises(TypeError):
+            pylong_export("abc")
+
     def test_long_import(self):
         # Test PyLong_Import()
         layout = _testcapi.get_pylong_layout()

Modules/_testcapi/long.c

@@ -163,13 +163,8 @@ pylong_import(PyObject *module, PyObject *args)
 static PyObject *
 pylong_export(PyObject *module, PyObject *obj)
 {
-    if (!PyLong_Check(obj)) {
-        PyErr_Format(PyExc_TypeError, "expect int, got %T", obj);
-        return NULL;
-    }
-
     PyUnstable_LongExport long_export;
-    if (PyUnstable_Long_Export((PyLongObject*)obj, &long_export) < 0) {
+    if (PyUnstable_Long_Export(obj, &long_export) < 0) {
         return NULL;
     }
 

Objects/longobject.c

@@ -6702,17 +6702,21 @@ PyUnstable_Long_Import(int negative, size_t ndigits, Py_digit *digits)
 
 
 int
-PyUnstable_Long_Export(PyLongObject *obj, PyUnstable_LongExport *long_export)
+PyUnstable_Long_Export(PyObject *obj, PyUnstable_LongExport *long_export)
 {
-    assert(PyLong_Check(obj));
+    if (!PyLong_Check(obj)) {
+        PyErr_Format(PyExc_TypeError, "expect int, got %T", obj);
+        return -1;
+    }
+    PyLongObject *self = (PyLongObject*)obj;
 
     long_export->obj = (PyLongObject*)Py_NewRef(obj);
-    long_export->negative = _PyLong_IsNegative(obj);
-    long_export->ndigits = _PyLong_DigitCount(obj);
+    long_export->negative = _PyLong_IsNegative(self);
+    long_export->ndigits = _PyLong_DigitCount(self);
     if (long_export->ndigits == 0) {
         long_export->ndigits = 1;
     }
-    long_export->digits = obj->long_value.ob_digit;
+    long_export->digits = self->long_value.ob_digit;
     return 0;
 }