add action method for parser compatibility check

Author: mattwang44

Lib/argparse.py

@@ -922,6 +922,10 @@ def format_usage(self):
     def __call__(self, parser, namespace, values, option_string=None):
         raise NotImplementedError('.__call__() not defined')
 
+    def _check_compatibility(self, container):
+        """Check whether the action is compatible with the container."""
+        pass
+
 
 class BooleanOptionalAction(Action):
     def __init__(self,
@@ -954,15 +958,16 @@ def __init__(self,
 
 
     def __call__(self, parser, namespace, values, option_string=None):
-        if '-' not in parser.prefix_chars:
-            raise ValueError("BooleanOptionalAction requires '-' in parser's prefix_chars")
-
         if option_string in self.option_strings:
             setattr(namespace, self.dest, not option_string.startswith('--no-'))
 
     def format_usage(self):
         return ' | '.join(self.option_strings)
 
+    def _check_compatibility(self, container):
+        if '-' not in container.prefix_chars:
+            raise ValueError(f"BooleanOptionalAction requires '-' in prefix_chars.")
+
 
 class _StoreAction(Action):
 
@@ -1545,6 +1550,9 @@ def add_argument(self, *args, **kwargs):
         if not action.option_strings and action.nargs == 0:
             raise ValueError(f'action {action_name!r} is not valid for positional arguments')
 
+        # raise an error if the action is not compatible with the parser
+        action._check_compatibility(self)
+
         # raise an error if the action type is not callable
         type_func = self._registry_get('type', action.type, action.type)
         if not callable(type_func):

Lib/test/test_argparse.py

@@ -797,13 +797,10 @@ def test_invalid_name(self):
 
     def test_prefix_chars_incompatibility(self):
         parser = argparse.ArgumentParser(prefix_chars='+')
-        parser.add_argument('++foo', action=argparse.BooleanOptionalAction)
-
         with self.assertRaises(ValueError) as cm:
-            parser.parse_args(['++foo'])
-
-        self.assertIn(str(cm.exception),
-                      "BooleanOptionalAction requires '-' in parser's prefix_chars")
+            parser.add_argument('++foo', action=argparse.BooleanOptionalAction)
+        self.assertEqual(str(cm.exception),
+                         "BooleanOptionalAction requires '-' in prefix_chars.")
 
 class TestBooleanOptionalActionRequired(ParserTestCase):
     """Tests BooleanOptionalAction required"""