Skip to content

Commit e38eab4

Browse files
committed
Don't declare unused variables and update test
1 parent ba3979d commit e38eab4

File tree

3 files changed

+13
-11
lines changed

3 files changed

+13
-11
lines changed

Lib/test/test_generated_cases.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -68,13 +68,15 @@ def test_effect_sizes(self):
6868
StackItem("b", None, "oparg*4"),
6969
StackItem("c", None, "1"),
7070
]
71-
stack.pop(z)
72-
stack.pop(y)
73-
stack.pop(x)
71+
null = CWriter.null()
72+
stack.pop(z, null)
73+
stack.pop(y, null)
74+
stack.pop(x, null)
7475
for out in outputs:
7576
stack.push(Local.undefined(out))
7677
self.assertEqual(stack.base_offset.to_c(), "-1 - oparg - oparg*2")
77-
self.assertEqual(stack.top_offset.to_c(), "1 - oparg - oparg*2 + oparg*4")
78+
self.assertEqual(stack.physical_sp.to_c(), "0")
79+
self.assertEqual(stack.logical_sp.to_c(), "1 - oparg - oparg*2 + oparg*4")
7880

7981

8082
class TestGeneratedCases(unittest.TestCase):

Python/generated_cases.c.h

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Tools/cases_generator/tier1_generator.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,11 @@ def declare_variables(inst: Instruction, out: CWriter) -> None:
5353
if not isinstance(part, Uop):
5454
continue
5555
for var in part.stack.inputs:
56-
if var.name not in seen:
56+
if var.used and var.name not in seen:
5757
seen.add(var.name)
5858
declare_variable(var, out)
5959
for var in part.stack.outputs:
60-
if var.name not in seen:
60+
if var.used and var.name not in seen:
6161
seen.add(var.name)
6262
declare_variable(var, out)
6363

0 commit comments

Comments
 (0)