Skip to content

Commit f6f9744

Browse files
Address review
1 parent eaa2a2e commit f6f9744

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

Python/optimizer.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -695,6 +695,7 @@ _PyJit_translate_single_bytecode_to_trace(
695695
// gh-143183: It's important we rewind to the last known proper target.
696696
// The current target might be garbage as stop tracing usually indicates
697697
// we are in something that we can't trace.
698+
DPRINTF(2, "Told to stop tracing\n");
698699
goto unsupported;
699700
}
700701

@@ -723,11 +724,6 @@ _PyJit_translate_single_bytecode_to_trace(
723724

724725
if (oparg > 0xFFFF) {
725726
DPRINTF(2, "Unsupported: oparg too large\n");
726-
goto unsupported;
727-
}
728-
729-
// TODO (gh-140277): The constituent use one extra stack slot. So we need to check for headroom.
730-
if (opcode == BINARY_OP_SUBSCR_GETITEM && old_stack_level + 1 > old_code->co_stacksize) {
731727
unsupported:
732728
{
733729
// Rewind to previous instruction and replace with _EXIT_TRACE.
@@ -749,6 +745,7 @@ _PyJit_translate_single_bytecode_to_trace(
749745
}
750746
}
751747

748+
752749
if (opcode == NOP) {
753750
return 1;
754751
}

0 commit comments

Comments
 (0)