Clean up

Author: matthiasgoergens

Modules/_collectionsmodule.c

@@ -614,7 +614,6 @@ static PyObject *
 deque_copy_impl(dequeobject *deque)
 /*[clinic end generated code: output=6409b3d1ad2898b5 input=51d2ed1a23bab5e2]*/
 {
-    // TODO(Matthias): we can actually copy via memcpy, instead of using extend.
     PyObject *result;
     dequeobject *old_deque = deque;
     collections_state *state = find_module_state_by_def(Py_TYPE(deque));
@@ -864,7 +863,6 @@ deque_repeat(PyObject *self, Py_ssize_t n)
     return rv;
 }
 
-// TODO(Matthias): Special case for length = allocated: we only need to move the first element, no memcpy.
 static int
 _deque_rotate(dequeobject *deque, Py_ssize_t n)
 {
@@ -1334,7 +1332,6 @@ deque_slice_lock_held(dequeobject *deque, PyObject *slice)
 static PyObject *
 deque_item_lock_held(dequeobject *deque, Py_ssize_t i)
 {
-    // TODO(Matthias): check whether we should support negative indices the usual way?
     Py_ssize_t n = Py_SIZE(deque);
     Py_ssize_t first = deque->first_element;
     Py_ssize_t mask = deque->allocated - 1;  // Since allocated is a power of 2
@@ -1391,9 +1388,6 @@ deque_subscript(PyObject *self, PyObject *item)
     return result;
 }
 
-// TODO(Matthias): this one is probably broken.
-// TODO(Matthias): optimise from which direction we shift to close the gap.
-// TODO(Matthias): check whether we need to decrease the reference count of the deleted item, or if our callers do that?
 static int
 deque_del_item(dequeobject *deque, Py_ssize_t i)
 {
@@ -1737,13 +1731,8 @@ deque_init_impl(dequeobject *deque, PyObject *iterable, PyObject *maxlenobj)
     deque->maxlen = maxlen;
 
     /* Initialize the ring buffer */
-    // TODO(Matthias): ok, here's where we set up to start with 8!!!
     deque->allocated = 0;  // Start with a power of 2
     deque->ob_item = NULL;
-    // if (deque->ob_item == NULL) {
-    //     PyErr_NoMemory();
-    //     return -1;
-    // }
     deque->first_element = 0;
     Py_SET_SIZE(deque, 0);
 
@@ -1986,10 +1975,6 @@ dequeiter_next(PyObject *op)
     Py_BEGIN_CRITICAL_SECTION2(it, it->deque);
     result = dequeiter_next_lock_held(it, it->deque);
     Py_END_CRITICAL_SECTION2();
-    // TODO(Matthias): is this needed?
-    // if (result == NULL) {
-    //     Py_DECREF(it);
-    // }
     return result;
 }
 
@@ -2139,8 +2124,6 @@ dequereviter_next(PyObject *self)
 static PyObject *
 dequereviter_new(PyTypeObject *type, PyObject *args, PyObject *kwds)
 {
-    // TODO(Matthias): check the implementation carefully.
-    // It's just cargo-culted from the deque version, but I don't know exactly what it's trying to do.
     Py_ssize_t i, index = 0;
     PyObject *deque;
     dequeiterobject *it;