Skip to content

Commit 8d36547

Browse files
jaracoezio-melottihugovkCAM-Gerlach
authored
Refine 'gaining commit privileges'. (#969)
* Refine 'gaining commit privileges'. - Allow the audience to be anybody (not just an individual seeking commit privileges). Avoids use of second-person language. - Provide guidance for all involved. - Refer to the various actors directly, avoiding passive language. Use 'candidate', 'submitter', and 'approver' to represent the key actors. - Move the "cross-post" action into step 1 to indicate better the temporal positition of the action. - Summarize the confirmation criterion (2/3 vote) rather than make the reader go to the PEP, which basically indicates 2/3 vote. - Include the steering council email, because the submitter may not know it. - Normalize the initial approver actions. Previously, council was directed to be "asking for ... a reminder about the Code of Conduct and to report issues to the PSF WG". Now it's two requests and a reminder. - Hyperlink "python/voters" instead of the full URL. * Combine steps Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> * Consolidate steps 5-8 into one. Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> * Update number. Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> * Link python-committers mailing list. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Remove unnecessary hostname. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> * Move cross-post instruction to step 1. * Auto number * Fix syntax. * Apply suggestions from code review Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com> Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
1 parent 353d41c commit 8d36547

File tree

1 file changed

+28
-26
lines changed

1 file changed

+28
-26
lines changed

core-developers/become-core-developer.rst

Lines changed: 28 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -25,37 +25,39 @@ an official offer. How core developers come to that agreement are outlined in
2525
Gaining Commit Privileges
2626
=========================
2727

28-
The steps to gaining commit privileges are:
28+
After a candidate has demonstrated consistent contributions, commit privileges
29+
are granted through these steps:
2930

30-
1. A core developer starts a poll in the
31-
`Committers category`_ on the `Python Discourse`_ (``discuss.python.org``)
31+
#. A core developer (submitter, usually the mentor) starts a poll in the
32+
`Committers category`_ on the `Python Discourse`_ and cross-posts it to
33+
the `python-committers mailing list`_.
3234

3335
- Open for 7 days
3436
- Results shown upon close
3537

36-
2. The poll is announced on the `python-committers mailing list`_
37-
3. Wait for the poll to close and see if the results confirm your membership
38-
as per the voting results required by :pep:`13`
39-
4. The person who nominated you emails the steering council with your email
40-
address and a request that the council either accept or reject the proposed
41-
membership
42-
5. Assuming the steering council does not object, a member of the council will
43-
email you asking for:
44-
45-
- Account details as required by
46-
🔒 https://github.com/python/voters/
47-
- Your preferred email address to
48-
subscribe to the python-committers mailing list with
49-
- A reminder about the `Code of Conduct`_ and to report issues to the PSF
50-
Conduct WG
51-
52-
6. Once you have provided the pertinent details, your various new privileges
53-
will be turned on
54-
7. Your details will be added to 🔒 https://github.com/python/voters/
55-
8. They will update the devguide to publicly list your team membership at
56-
:ref:`developers`
57-
9. An announcement email by the steering council member handling your new
58-
membership will be sent to the Committers Discourse category
38+
#. If the candidate receives at least two-thirds positive votes when the poll closes
39+
(as per :pep:`13`), the submitter `emails the steering council
40+
<mailto:steering-council@python.org>`_ with the candidate's email address
41+
requesting that the council either accept or reject the proposed membership.
42+
43+
#. Assuming the steering council does not object, a member of the council or delegate
44+
(approver) will email the candidate:
45+
46+
- A request for account details as required by
47+
`🔒 python/voters <https://github.com/python/voters>`_
48+
- A request for the committer's preferred address for subscription to
49+
the `python-committers mailing list`_
50+
- A reminder about the `Code of Conduct`_ and guidance on reporting issues
51+
to the PSF Conduct WG
52+
53+
#. Once the candidate has provided the pertinent details, the approver will:
54+
55+
- enable the various new privileges;
56+
- add the new committer's details to
57+
`🔒 python/voters <https://github.com/python/voters>`_;
58+
- update the devguide to publicly list the new committer's team membership
59+
at :ref:`developers`;
60+
- send an announcement email to the Committers Discourse category.
5961

6062
.. _Code of Conduct: https://www.python.org/psf/conduct/
6163
.. _Committers category: https://discuss.python.org/c/committers/5

0 commit comments

Comments
 (0)