Fix formatting warnings for PyBytesWriter_Format

amolenaar · amolenaar · commit ec79422c7697 · 2025-10-03T09:19:01.000+02:00
Add C formatting warnings and fix declaration.
diff --git a/pythoncapi_compat.h b/pythoncapi_compat.h
@@ -2529,6 +2529,9 @@ PyBytesWriter_WriteBytes(PyBytesWriter *writer,
     return 0;
 }
 
+static inline int PyBytesWriter_Format(PyBytesWriter *writer, const char *format, ...)
+                                                Py_GCC_ATTRIBUTE((format(printf, 2, 0)));
+
 static inline int
 PyBytesWriter_Format(PyBytesWriter *writer, const char *format, ...)
 {
diff --git a/tests/setup.py b/tests/setup.py
@@ -34,7 +34,11 @@
         '-Wconversion',
         # /usr/lib64/pypy3.7/include/pyport.h:68:20: error: redefinition of typedef
         # 'Py_hash_t' is a C11 feature
-        "-Wno-typedef-redefinition",
+        '-Wno-typedef-redefinition',
+        # Formatting checks
+        '-Wformat',
+        '-Wformat-nonliteral',
+        '-Wformat-security',
     ))
     CFLAGS = COMMON_FLAGS + [
         # Use C99 for pythoncapi_compat.c which initializes PyModuleDef with a

Original file line number	Diff line number	Diff line change
`@@ -2529,6 +2529,9 @@ PyBytesWriter_WriteBytes(PyBytesWriter *writer,`
`2529`	`2529`	`return 0;`
`2530`	`2530`	`}`
`2531`	`2531`
	`2532`	`+static inline int PyBytesWriter_Format(PyBytesWriter writer, const char format, ...)`
	`2533`	`+ Py_GCC_ATTRIBUTE((format(printf, 2, 0)));`
	`2534`	`+`
`2532`	`2535`	`static inline int`
`2533`	`2536`	`PyBytesWriter_Format(PyBytesWriter writer, const char format, ...)`
`2534`	`2537`	`{`