fix: handle release objects with 'invalid' names

Author: JacobCoffee

downloads/models.py

@@ -128,8 +128,11 @@ def get_version(self):
         return None
 
     def is_version_at_least(self, min_version_tuple):
+        version = self.get_version()
+        if version is None:
+            return False
         v1 = []
-        for b in self.get_version().split('.'):
+        for b in version.split('.'):
             try:
                 v1.append(int(b))
             except ValueError:

downloads/tests/test_models.py

@@ -87,3 +87,11 @@ def test_is_version_at_least(self):
         release_310 = Release.objects.create(name='Python 3.10.0')
         self.assertTrue(release_310.is_version_at_least_3_9)
         self.assertTrue(release_310.is_version_at_least_3_5)
+
+    def test_is_version_at_least_with_invalid_name(self):
+        """Test that is_version_at_least returns False for releases with invalid names"""
+        invalid_release = Release.objects.create(name='Python install manager')
+        # Should return False instead of raising AttributeError
+        self.assertFalse(invalid_release.is_version_at_least_3_5)
+        self.assertFalse(invalid_release.is_version_at_least_3_9)
+        self.assertFalse(invalid_release.is_version_at_least_3_14)