Skip to content

Commit ebfc2bc

Browse files
authored
Update ci.yml (#220)
* Update ci.yml * Updated code formatting and fixed CI (#221) * Updated code formatting * Delete package-lock.json * Fixed CI issue and updated dep version * Updated netlify build env * added --expect 200 * Added fix for Node17+, bahmutov/start-server-and-test#333
1 parent f137219 commit ebfc2bc

File tree

26 files changed

+151
-216
lines changed

26 files changed

+151
-216
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,13 @@ jobs:
3737
test: launch
3838
steps:
3939
- uses: actions/checkout@v3
40-
- uses: actions/setup-python@v3
40+
- uses: actions/setup-python@v4
4141
with:
42-
python-version: 3.6
42+
python-version: 3.9
4343

4444
- uses: actions/setup-node@v3
4545
with:
46-
node-version: 14
46+
node-version: 18
4747

4848
- uses: actions/cache@v3
4949
with:
@@ -88,13 +88,13 @@ jobs:
8888
runs-on: ubuntu-latest
8989
steps:
9090
- uses: actions/checkout@v3
91-
- uses: actions/setup-python@v3
91+
- uses: actions/setup-python@v4
9292
with:
93-
python-version: 3.8
93+
python-version: 3.9
9494

9595
- uses: actions/setup-node@v3
9696
with:
97-
node-version: 14
97+
node-version: 16
9898

9999
- uses: actions/cache@v3
100100
with:

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ To add a new template,
109109
pnpm run lint
110110
```
111111

112-
- To ensure the codebase complies with a style guide, we use black and isort tools to format and check codebase for compliance with PEP8. Install and run with:
112+
- To ensure the codebase complies with a style guide, we use black and ufmt to format and check codebase for compliance with PEP8. Install and run with:
113113

114114
```sh
115115
# install code formatting dependencies

netlify.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
[build.environment]
2+
NODE_VERSION = "18"
3+
PYTHON_VERSION = "3.8"
4+
15
[build]
26
publish = "./dist"
37
command = "npx pnpm i --frozen-lockfile --store=node_modules/.pnpm-store && npx pnpm run build"

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"build": "vite build",
77
"serve": "vite preview",
88
"test": "jest --color --runInBand",
9-
"test:ci": "start-server-and-test serve 5000 test",
9+
"test:ci": "start-server-and-test --expect 200 serve http://127.0.0.1:5000 test",
1010
"release": "node scripts/release.js",
1111
"fmt": "prettier --write . && bash scripts/run_code_style.sh fmt",
1212
"lint": "prettier --check . && bash scripts/run_code_style.sh lint",
@@ -32,7 +32,7 @@
3232
"prismjs": "^1.26.0",
3333
"prompts": "^2.4.2",
3434
"semver": "^7.3.5",
35-
"start-server-and-test": "^1.14.0",
35+
"start-server-and-test": "^1.15.3",
3636
"uuid": "^8.3.2",
3737
"vite": "^2.7.13",
3838
"vue": "^3.2.30",

0 commit comments

Comments
 (0)