From 9c3ee9bccc074bcf80503e9e503c20d6f350170c Mon Sep 17 00:00:00 2001 From: elliot Date: Wed, 24 Sep 2025 16:34:43 -0400 Subject: [PATCH 1/2] Fix cell executor selection logic so bash cell execution works --- apps/vscode/src/host/executors.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/vscode/src/host/executors.ts b/apps/vscode/src/host/executors.ts index af23290e..96035dab 100644 --- a/apps/vscode/src/host/executors.ts +++ b/apps/vscode/src/host/executors.ts @@ -153,7 +153,11 @@ const csharpCellExecutor: VSCodeCellExecutor = { const bashCellExecutor: VSCodeCellExecutor = { language: "bash", execute: async (blocks: string[]) => { - const terminal = window.activeTerminal || window.createTerminal(); + // todo: this should probably check that the terminal isn't an interactive terminal for languages + // other than R as well... + const terminal = window.activeTerminal && window.activeTerminal?.name !== 'R Interactive' ? + window.activeTerminal : window.createTerminal(); + terminal.show(); terminal.sendText(blocks.join("\n")); }, @@ -283,7 +287,7 @@ export async function ensureRequiredExtension( } } } else { - return false; + return true; } } From 32ef84db7159c92d2ee289b773a573d2a8691801 Mon Sep 17 00:00:00 2001 From: elliot Date: Fri, 16 Jan 2026 15:53:46 -0500 Subject: [PATCH 2/2] Add changelog entry --- apps/vscode/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/apps/vscode/CHANGELOG.md b/apps/vscode/CHANGELOG.md index 4e7443ca..2f7505a6 100644 --- a/apps/vscode/CHANGELOG.md +++ b/apps/vscode/CHANGELOG.md @@ -4,6 +4,7 @@ - Fixed Copilot completions in `.qmd` documents (). - Fixed a bug where the `autoDetectColorScheme` setting could cause equation previews to have a dark text on dark background and vice versa (). +- Fix a regression where bash cell execution does not work (). ## 1.128.0 (Release on 2026-01-08)